{{ message }}
⚡ Bolt: optimize filesystem reads by removing TOCTOU checks - #60
Merged
Tcode-Motion merged 1 commit intoSep 5, 2026
Merged
Conversation
Refactored `cache.rs`, `config.rs`, and `project.rs` in `techscript_cli` to remove redundant `.exists()` checks prior to `fs::read()` and `fs::read_to_string()`. Matches directly on the `Result` from the file read instead to eliminate an unnecessary `stat` system call on hot compilation paths, resolving a Time-of-Check to Time-of-Use race condition and cutting filesystem overhead by ~50% per lookup. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
Contributor
Tcode-Motion
marked this pull request as ready for review
September 5, 2026 05:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Removed redundant
Path::exists()checks that occurred immediately prior tostd::fs::readandstd::fs::read_to_stringoperations withintechscript_cli.🎯 Why: Calling
.exists()before opening a file is a performance anti-pattern. It introduces a Time-of-Check to Time-of-Use (TOCTOU) race condition and doubles the required filesystem operations by mandating astatsyscall prior to everyopen/read.📊 Impact: Eliminates redundant
statsystem calls in critical path loops such as configuration parsing, module cache checking, and workspace manifest resolution. This is expected to tangibly speed up incremental compilation, especially on environments with high file I/O latency (like certain CI or remote containers).🔬 Measurement: Verify by running
strace -c -e statx,openat tsc run ...and observing a significant reduction instatxcalls. Ensure CLI still handles missing configs gracefully.PR created automatically by Jules for task 13392758860696189895 started by @Tcode-Motion