{{ message }}
Repository navigation
chore(deps): update svelte-virtual peerDependencies to allow for v5 - #863
Merged
Merged
Conversation
wobsoriano
reviewed
Oct 26, 2024
wobsoriano
left a comment
wobsoriano
left a comment
There was a problem hiding this comment.
I believe it's safe to remove v3 as peer dep. What do you think?
Contributor
Author
Collaborator
that is good question, maybe let's leave the v3 for now. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 209dd02. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Contributor
Author
|
So add v3 support back? |
Collaborator
…ncy" This reverts commit 771615e. As per discussion v3 should remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Svelte v5 was just released and is backward compatible with v4. This updates the peerDependencies to allow for those running Svelte 5 projects to pull in this dependency.
For reference:
https://svelte.dev/blog/svelte-5-is-alive