{{ message }}
Repository navigation
test(marko-virtual): mark chat "Latest" e2e as fixme pending #1267 - #1278
Merged
Merged
Conversation
…#1267 Same prepend race TanStack#1268 disabled in the chat-pretext spec, still enabled in the plain chat spec and failing on CI for unrelated PRs (TanStack#1248, TanStack#1272). Re-enable once TanStack#1267 is fixed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit 350e73e
☁️ Nx Cloud last updated this comment at |
mattwilkinsonn
added a commit
to RigelBuild/virtual
that referenced
this pull request
Oct 10, 2026
…35) (#5) * test(marko-virtual): mark chat-pretext "Latest" e2e as fixme pending TanStack#1267 (TanStack#1268) * fix(virtual-core): re-issue clamped end-anchor compensation once the sizer grows (TanStack#1260) * feat(lit-virtual): re-export the virtual-core public API (TanStack#1264) * ci: Version Packages (TanStack#1269) * docs(react-virtual): replace ReactDOM.render with createRoot in examples (TanStack#1192) * fix(virtual-core): preserve measurement keys and follow sliding windows (TanStack#1272) * docs: remove duplicate page headings (TanStack#1275) * docs(angular-virtual): remove deprecated allowSignalWrites from examples (TanStack#1274) * ci: Version Packages (TanStack#1277) * test(marko-virtual): mark chat "Latest" e2e as fixme pending TanStack#1267 (TanStack#1278) * fix(virtual-core): keep a travelling smooth scroll alive through a prepend (TanStack#1248) * fix(virtual-core): refresh offset in scroll-end fallback (TanStack#1284) * test(react-virtual): wait for smooth scrolls to settle instead of a fixed 2s (TanStack#1289) * fix(react-virtual): skip flushSync while measuring from the ref callback (TanStack#1282) * ci: Version Packages (TanStack#1279) * fix(virtual-core): stop scrollToIndex(last, { align: 'end' }) overshooting by paddingEnd (TanStack#1276) * fix(virtual-core): skip sync measurement of detached nodes (TanStack#1293) * feat(virtual-core): add cancelScroll() to stop an in-flight scroll reconciliation (TanStack#1300) * fix(react-virtual): position directDomUpdates rows that mount without the owner (TanStack#1301) * fix(virtual-core): reconcile index scrolls after pending measurements (TanStack#1294) * ci: Version Packages (TanStack#1299) * ci: run push workflows and nx affected against rigel-release (RIG-5035) main now mirrors TanStack/virtual, so the fork's push-triggered autofix and zizmor runs and the nx-affected base move to rigel-release, the branch that carries Rigel changes. Co-authored-by: Matt Wilkinson <matt@rigel.build> * ci(autofix): drop the push trigger on rigel-release (RIG-5035) The rigel-release ruleset refuses non-PR pushes, so autofix.ci could never apply a fix there. It keeps running on pull requests, where it updates the PR head. Co-authored-by: Matt Wilkinson <matt@rigel.build> --------- Co-authored-by: Damian Pieczynski <piecyk@gmail.com> Co-authored-by: Gianluca Guarini <gianluca.guarini@gmail.com> Co-authored-by: Ben Younes <benyounes.ousama@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Nikhil Dabhade <48783530+nikhilsdabhade@users.noreply.github.com> Co-authored-by: lisw <lisw@paraflow.com> Co-authored-by: Kevin Van Cott <kevinvandy656@gmail.com> Co-authored-by: rubinsh <rubinsh@gmail.com> Co-authored-by: 김지우 <jiwook97@gmail.com> Co-authored-by: Dikshit <62920150+dikshit-n@users.noreply.github.com> Co-authored-by: Ted <36294843+webn00b@users.noreply.github.com> Co-authored-by: Minwook Shin <163576506+minwookshin@users.noreply.github.com> Co-authored-by: Matt Wilkinson <matt@rigel.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plain chat spec's "Latest returns to the bottom and status flips back to At latest" hits the same prepend race that #1268 disabled in the chat-pretext spec, and it is failing CI on unrelated PRs (#1248, #1272). Latest is clicked while the near-top auto history load is in flight; the prepend resolves after the jump and the adapter's anchor write is clamped against the not-yet-grown sizer, so the status stays "Reading history".
🎯 Changes
test.fixmewith a FIXME pointing at marko-virtual: scrollToEnd during an in-flight prepend strands the view one prepend above the bottom (chat-pretext e2e fails on CI) #1267, mirroring test(marko-virtual): mark chat-pretext "Latest" e2e as fixme pending #1267 #1268.Re-enable once #1267 is fixed (#1273).
✅ Checklist
pnpm run test:pr.🚀 Release Impact
🤖 Generated with Claude Code
Summary by CodeRabbit
Tests
User Impact