{{ message }}
Repository navigation
docs(virtual-core): clarify shouldAdjustScrollPositionOnItemSizeChange usage - #1234
Merged
piecyk merged 1 commit intoJul 22, 2026
Conversation
xianjianlf2
marked this pull request as ready for review
July 20, 2026 04:20
|
View your CI Pipeline Execution ↗ for commit dff54b7
☁️ Nx Cloud last updated this comment at |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies that
shouldAdjustScrollPositionOnItemSizeChangeis a Virtualizer instance property, not aVirtualizerOptionsoption.The existing docs already list it under Virtualizer Instance, but the prose and changelog wording could still be read as passing the predicate through options. This updates both places to show the intended imperative assignment form.
References #1227 and follows up on the maintainer feedback in #1232.
Validation:
./node_modules/.bin/prettier --check docs/api/virtualizer.md packages/virtual-core/CHANGELOG.mdSummary by CodeRabbit
shouldAdjustScrollPositionOnItemSizeChangeis configured directly on the virtualizer instance.