iframe-proxy

piecyk · 2026-06-15T18:56:13Z

🎯 Changes

Make directDomUpdates a no-op for direct DOM writes when containerRef is omitted. Previously the virtualizer still wrote item positions while never sizing the container (a broken half-state). Now omitting containerRef skips all direct writes while still skipping re-renders, letting consumers own the DOM updates themselves (e.g. in onChange).

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Bug Fixes
- Fixed direct DOM update behavior when a container reference is not provided; now properly skips all DOM writes instead of partial updates.
Documentation
- Updated documentation clarifying direct DOM update behavior without a container reference.
Tests
- Added test coverage for direct DOM updates without container reference.

coderabbitai · 2026-06-15T18:56:26Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bbebe4b1-f2b9-4057-81ba-868ffae5bffa

📥 Commits

Reviewing files that changed from the base of the PR and between ef69ea3 and 4dd2834.

📒 Files selected for processing (5)

.changeset/direct-dom-no-container.md
docs/framework/react/react-virtual.md
packages/react-virtual/e2e/app/direct-dom-updates/main.tsx
packages/react-virtual/e2e/app/test/direct-dom-updates.spec.ts
packages/react-virtual/src/index.tsx

📝 Walkthrough

Walkthrough

When directDomUpdates is enabled but containerRef is omitted, applyDirectStyles now returns early before computing getTotalSize() or applying any container/item styles. An e2e test app gains a noContainer query-parameter mode and a new Playwright spec verifies no DOM writes occur while re-renders remain skipped. Documentation and a changeset entry describe the updated behavior.

Changes

directDomUpdates no-op without containerRef

Layer / File(s)	Summary
`applyDirectStyles` early-return guard `packages/react-virtual/src/index.tsx`	Broadens the early-return condition to also check `state.container`, preventing container sizing and item positioning writes when `containerRef` is absent.
E2E fixture `noContainer` flag and Playwright test `packages/react-virtual/e2e/app/direct-dom-updates/main.tsx`, `packages/react-virtual/e2e/app/test/direct-dom-updates.spec.ts`	Adds a `noContainer=1` URL flag that passes `undefined` as the scroll container ref, and a Playwright test asserting no DOM style writes occur while render-skip semantics are preserved.
Changeset and docs `.changeset/direct-dom-no-container.md`, `docs/framework/react/react-virtual.md`	Adds a patch changeset entry and a documentation note clarifying that omitting `containerRef` disables all direct DOM writes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

TanStack/virtual#1180: Introduced the directDomUpdates feature and the applyDirectStyles function that this PR modifies to guard against a missing containerRef.

Poem

🐇 Hop hop, the container's not there,
No styles shall be written—I swear!
With state.container null,
We skip the whole call,
And re-renders? Still skipped! How fair! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly summarizes the main change: making directDomUpdates a no-op without containerRef, which is the core modification in this PR.
Description check	✅ Passed	The description follows the template structure with completed 🎯 Changes, ✅ Checklist (all items checked), and 🚀 Release Impact sections, providing clear context for the change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-06-15T18:57:15Z

View your CI Pipeline Execution ↗ for commit 4dd2834

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	43s	View ↗
`nx run-many --target=build --exclude=examples/**`	✅ Succeeded	16s	View ↗

☁️ Nx Cloud last updated this comment at 2026-06-15 18:57:47 UTC

pkg-pr-new · 2026-06-15T18:57:43Z

fix(react-virtual): make directDomUpdates a no-op without containerRef

4dd2834

piecyk merged commit 2ba5eb6 into TanStack:main Jun 15, 2026
10 checks passed

github-actions Bot mentioned this pull request Jun 15, 2026

ci: Version Packages #1202

Merged

coderabbitai Bot mentioned this pull request Jul 20, 2026

fix(react-virtual): grow size container before scroll sync on end-anchored prepend #1237

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

fix(react-virtual): make directDomUpdates a no-op without containerRef - #1201

fix(react-virtual): make directDomUpdates a no-op without containerRef#1201
piecyk merged 1 commit into
TanStack:mainfrom
piecyk:fix/direct-dom-updates-no-container

piecyk commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloud Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jun 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

piecyk commented Jun 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloud Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jun 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

piecyk commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

nx-cloud Bot commented Jun 15, 2026 •

edited

Loading