You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Document the React Compiler workaround for useRanger, including directive placement and the limits of memoizing the instance. Verified dragging, keyboard input and controlled updates with Compiler 1.0.0 in Chromium, Firefox and WebKit.
Refs #106; this documents a temporary workaround, not full compiler compatibility.
Validation: docs formatting and link checks, package builds and types, and a browser comparison of compiled, uncompiled and opt-out sliders against the current source.
Summary by CodeRabbit
Documentation
Added React Compiler guidance for avoiding stale slider handles and aria-valuenow values when using useRanger, including a temporary workaround and a link to track updates.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 0062f043-51b2-4970-91f3-04a64cf44f38
📥 Commits
Reviewing files that changed from the base of the PR and between fef4517 and 1860221.
📒 Files selected for processing (1)
docs/framework/react/react-ranger.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
Walkthrough
The React Ranger documentation adds guidance about stale reads from the stable mutable useRanger instance when React Compiler is enabled. It documents a temporary 'use no memo' workaround, cautions against memoizing instance-dependent reads, and links to issue #106.
Changes
React Compiler guidance
Layer / File(s)
Summary
Compiler behavior and workaround docs/framework/react/react-ranger.md
The documentation describes stale slider handles and aria-valuenow reads, a component-level 'use no memo' workaround, restrictions on memoizing instance-dependent reads, and an issue link.
This documentation change has no identified merge-blocking risk and is ready for normal checks.
Pre-merge checks | 5
✅ Passed checks (5 passed)
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main documentation change: explaining the React Compiler workaround for useRanger.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the React Compiler workaround for
useRanger, including directive placement and the limits of memoizing the instance. Verified dragging, keyboard input and controlled updates with Compiler 1.0.0 in Chromium, Firefox and WebKit.Refs #106; this documents a temporary workaround, not full compiler compatibility.
Validation: docs formatting and link checks, package builds and types, and a browser comparison of compiled, uncompiled and opt-out sliders against the current source.
Summary by CodeRabbit
aria-valuenowvalues when usinguseRanger, including a temporary workaround and a link to track updates.