fix(solid-query-devtools): declare the Web peer and public JSX return type by BleedingDev · Pull Request #12160 · TanStack/query · GitHub
Skip to content

fix(solid-query-devtools): declare the Web peer and public JSX return type - #12160

Open
BleedingDev wants to merge 1 commit into
TanStack:solid-query-v6-prefrom
BleedingDev:fix/solid2-devtools-public-return-20261019
Open

fix(solid-query-devtools): declare the Web peer and public JSX return type#12160
BleedingDev wants to merge 1 commit into
TanStack:solid-query-v6-prefrom
BleedingDev:fix/solid2-devtools-public-return-20261019

Conversation

@BleedingDev

@BleedingDev BleedingDev commented Oct 19, 2026

Copy link
Copy Markdown

🎯 Changes

Why the change

Solid 2 Devtools must expose a public JSX return type and declare the Web package that its published code and declarations import.

Special things to note

  • This targets solid-query-v6-pre, which already supports Solid 2.
  • The Web peer uses the same supported range as Solid Query, >=2.0.0-rc.13 <3.0.0.
  • I used Codex to prepare this change and checked the complete diff. Equivalent fork builds and packed consumer type checks passed, but I have not run pnpm run test:pr on this upstream branch.

Change outline

 SolidQueryDevtools(props)
-  inferred return type
+  JSX.Element from @solidjs/web

 @tanstack/solid-query-devtools
+  required peer: @solidjs/web

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot

changeset-bot Bot commented Oct 19, 2026

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a0dc5ed2-2ca3-45f4-a3e7-8edb2885c4e6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T20:24:00.617683Z 7293a7f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BleedingDev