{{ message }}
Repository navigation
fix(solid-query): don't bump the query version on observer-only cache events - #12126
Open
S-jooyoung wants to merge 1 commit into
Open
S-jooyoung wants to merge 1 commit into
S-jooyoung wants to merge 1 commit into
Conversation
… events `setOptions` in the options render effect emits observer events (`observerAdded`, `observerResultsUpdated`, ...) after a key switch. `onCacheEvent` bumped `version` for all of them, so the data projection ran a second time in a later flush and Solid's diagnostics reported EFFECT_RELAY_TEAR. Bump `version` only for state events (`added`, `removed`, `updated`). `observerResultsUpdated` is still how a query going stale by time reaches `isStale`, so it bumps a separate signal that only `isStale` reads. Closes TanStack#11903
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎯 Changes
Closes #11903.
onCacheEventbumpedversionfor every cache event on the hook's hash. After a key switch,observer.setOptionsin the options render effect emits observer events (observerAdded,observerOptionsUpdated,observerResultsUpdated), so the data projection ran a second time in a later flush. That second run is what Solid's diagnostics report asEFFECT_RELAY_TEAR.versionnow moves only on state events (added,removed,updated).observerResultsUpdatedstill has to reachisStale, since it is how a query going stale by time is reported (two existinguseQuery.test.tsxtests fail without it), so it bumps a separate signal that onlyisStalereads.The new tests in
useQuery-semantics.test.tsxpin one data-projection recompute per switch to a cached key (and back), counted throughselect:[2, 2, 2]before (observer + projection twice),[2, 2]after.Checked locally with
@solidjs/diagnostics@2.0.0-rc.13(not added to the repo): the cached and switch-back scenarios from the issue no longer logEFFECT_RELAY_TEAR, with identical rendered output. Not covered:query.isStalestill recomputes twice on a key switch;staleTime: 0) still logsABANDONED_FLIGHTSandEFFECT_RELAY_TEAR(same output before and after this change).Note: this PR description was drafted with AI assistance. The AI policy box is left unchecked for that reason.
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact