{{ message }}
Repository navigation
fix(query-persist-client-core): catch persist errors in the subscriber - #11718
Open
mgarcia-improving wants to merge 1 commit into
Open
mgarcia-improving wants to merge 1 commit into
mgarcia-improving wants to merge 1 commit into
Conversation
A failing persister or dehydrate callback was an unhandled rejection because persistQueryClientSubscribe dropped the save promise.
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
persistQueryClientSubscribecalledpersistQueryClientSaveand ignored the promise. When a custom persister rejected, or adehydrateOptionscallback threw, that became an unhandled rejection on each cache update.The subscriber now catches that error. In development it logs it, the same way restore does. Calling
persistQueryClientSavedirectly still rejects, so callers that await it are unchanged.Fixes #11663.
There is another open PR for this, #11678. This is a separate take on the same fix.
✅ Checklist
pnpm nx run @tanstack/query-persist-client-core:test:lib(58 passed). I did not run the fullpnpm run test:prsuite.🚀 Release Impact
Summary by CodeRabbit