{{ message }}
fix(core): run all types of async validation on fields during submit#852
Merged
Balastrong merged 2 commits intoOct 1, 2024
Merged
Conversation
fkworld
force-pushed
the
fix-submit-trigger-async-validators
branch
from
058262c to
f14041d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
- Coverage 91.55% 88.19% -3.36%
==========================================
Files 21 26 +5
Lines 900 932 +32
Branches 206 209 +3
==========================================
- Hits 824 822 -2
- Misses 71 102 +31
- Partials 5 8 +3 ☔ View full report in Codecov by Sentry. |
fkworld
force-pushed
the
fix-submit-trigger-async-validators
branch
from
f14041d to
b23ef65
Compare
Contributor
Author
Balastrong
approved these changes
Oct 1, 2024
Balastrong
left a comment
Balastrong
left a comment
Member
There was a problem hiding this comment.
The fix was included in #656 but the test remains valid, I'm merging it. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #851
In
validateSyncfunction,validateObj.causeis used instead ofcause. I think they should be same.