{{ message }}
Fix sizeThatFits: and textInsets#730
Open
gskbyte wants to merge 5 commits into
Open
Conversation
added 2 commits
November 17, 2016 16:46
gskbyte
changed the title
segiddins
reviewed
Nov 17, 2016
Contributor
Author
There was a problem hiding this comment.
It's actually not necessary, I will remove it in the next commit.
Member
|
This needs to pass on CI |
Contributor
Author
|
The build failed in the CI because of a timeout and I can't retrigger it (the CircleCI API returns permission denied). Could you please retry it? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue of size not properly computed when
textInsetshave a value different toUIEdgeInsetsZero, which could provoke the following bug:A test has been added to prove that the fix works. There is also a change to avoid an unnecessary allocation inside
sizeThatFits:when theattributedTruncationTokenis not set.Thanks for this great library!