{{ message }}
NSBaseLineOffsetAttributeName support#604
Open
xmas79 wants to merge 4 commits into
Open
Conversation
Added the support for NSBaseLineOffsetAttributeName in the attributed string. Please review the code. Thanks, xmas79.
NSBaseLineOffsetAttributeName support
Contributor
|
Thanks for the PR, @xmas79. Can you please add some automated tests to cover this change and I'll merge it in? |
Author
|
Hello, Xcode version '6.3.1' is not available. Available versions are: 6.4, 7.0, 7.1 I don't know how to proceed. Thanks, |
Member
|
Circle has been fixed, but this still needs test coverage & a rebase to be mergable |
Member
|
Unless I am doing something incorrectly, it does not appear that this will offset any text above it. I.E. it will render on top of other lines of text if the offset is large enough. |
idcuesta
added a commit
to SolarCS/TTTAttributedLabel
that referenced
this pull request
Jan 20, 2020
idcuesta
added a commit
to SolarCS/TTTAttributedLabel
that referenced
this pull request
Jan 20, 2020
idcuesta
added a commit
to SolarCS/TTTAttributedLabel
that referenced
this pull request
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSBaseLineOffsetAttributeName attribute support. Please review the code.
Thanks,
xmas79.