{{ message }}
Fix MPV socket getting created in CWD#675
Merged
Merged
Conversation
notpeelz
commented
Apr 7, 2024
notpeelz
force-pushed
the
fix-mpv-socket-path
branch
2 times, most recently
from
6e94def to
0690aa1
Compare
notpeelz
commented
Apr 7, 2024
notpeelz
force-pushed
the
fix-mpv-socket-path
branch
3 times, most recently
from
f6fec7c to
7280bb7
Compare
notpeelz
force-pushed
the
fix-mpv-socket-path
branch
from
7280bb7 to
df33187
Compare
Contributor
Contributor
Author
|
I could pass the socket path via the Edit: I updated the PR. Let me know if there's anything else. |
notpeelz
force-pushed
the
fix-mpv-socket-path
branch
from
df33187 to
1f1cbc6
Compare
notpeelz
force-pushed
the
fix-mpv-socket-path
branch
from
1f1cbc6 to
6c5e3a1
Compare
daniel-123
approved these changes
Apr 28, 2024
Et0h
approved these changes
Apr 29, 2024
Et0h
left a comment
Et0h
left a comment
Contributor
There was a problem hiding this comment.
I have tested in Windows by confirming that mpv works and by using using Power Shell and [System.IO.Directory]::GetFiles("\\.\\pipe\\") to confirm that by default it will create a pipe along the lines of \\.\\pipe\\syncplay-mpv-94244417144407 but that if you add a player argument such as input-ipc-server=\\.\pipe\foobar it will also create a pipe of the specified name.
Contributor
This was referenced Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #674
I haven't tested on Windows or MacOS.