[WIP] Correct Finnish localizations by Mikaela · Pull Request #563 · Syncplay/syncplay · GitHub
Skip to content

[WIP] Correct Finnish localizations#563

Merged
Et0h merged 4 commits into
Syncplay:Finnish_Translationfrom
Mikaela:l10n-fi
Feb 28, 2023
Merged

[WIP] Correct Finnish localizations#563
Et0h merged 4 commits into
Syncplay:Finnish_Translationfrom
Mikaela:l10n-fi

Conversation

@Mikaela

@Mikaela Mikaela commented Nov 5, 2022

Copy link
Copy Markdown

I am performing code --diff messages_fi.py messages_en.py and attempting to correct what I see wrong with #561.

I am not able to correct everything or see some parts aren't great, so other localizers would be welcome. I am also taking liberties especially where I just don't see a way for the English wording working translated directly.

Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py

@Mikaela Mikaela left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally submit two oneliner comments instead of making finalised review, where I may be attempting to justify my decisions a bit too hard compared to actually correcting the localization.

Comment thread syncplay/messages_fi.py Outdated
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py Outdated
Comment thread syncplay/messages_fi.py Outdated
Comment thread syncplay/messages_fi.py

@Mikaela Mikaela left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't continue as much as I wished and did this a bit too late cutting to my bedtime, but this is not a race.

Comment thread syncplay/messages_fi.py Outdated
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py
Comment thread syncplay/messages_fi.py

@Mikaela Mikaela left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of notes to self that came up

Comment thread syncplay/messages_fi.py Outdated
Comment thread syncplay/messages_fi.py Outdated
@Et0h

Et0h commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

@Mikaela

Mikaela commented Dec 22, 2022

Copy link
Copy Markdown
Author

I will, my apologies for the delay, I want to get this done and feel guilty for the lack of progress.

I have been having challenges with mental and physical health and xmas is always somewhat difficult time for me.

@Et0h

Et0h commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

I will, my apologies for the delay, I want to get this done and feel guilty for the lack of progress.

I have been having challenges with mental and physical health and xmas is always somewhat difficult time for me.

Syncplay development is voluntary, so please prioritise your health and take as long as you need.

@Et0h

Et0h commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

@Mikaela Would it be fine for me to merge the work you've done so far so that others can work on the translation, and then you can work on the translation further if and when you are in the right place based on the latest version?

@Mikaela

Mikaela commented Feb 8, 2023

Copy link
Copy Markdown
Author

@Mikaela Mikaela marked this pull request as ready for review February 8, 2023 06:03
@Et0h Et0h merged commit 871f7cf into Syncplay:Finnish_Translation Feb 28, 2023
Et0h added a commit that referenced this pull request Mar 14, 2023
* Add initial Finnish translation (credit: LINUX-SAUNA)
* Improvements by Mikaela (#563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants