{{ message }}
fix(icon): use more distinct path for icon#432
Merged
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous fix for the icon to work on Plasma (#392) broke icon display
on Gnome. It looks as though the appindicator logic in Gnome doesn't
properly scan subdirectories for icons like KDE does (#421). Setting the
full path to our icon allows Gnome appindicator to work, along with
plasma still working as well. This also fixes the issue with ironbar (#428)
as it also seems to just pick the first icon it can find that matches
the name instead of looking in the correct path.
Tested against the following setups: