[FEAT]: Better Store Badges by G4PLS · Pull Request #410 · StreamController/StreamController · GitHub
Skip to content

[FEAT]: Better Store Badges#410

Merged
Core447 merged 29 commits into
StreamController:mainfrom
G4PLS:store-badge-rework
Dec 30, 2025
Merged

[FEAT]: Better Store Badges#410
Core447 merged 29 commits into
StreamController:mainfrom
G4PLS:store-badge-rework

Conversation

@G4PLS

@G4PLS G4PLS commented May 29, 2025

Copy link
Copy Markdown
Member

I have reworked the badges to be easy to add and requiring less space.
They also look better but thats just my opinion

@G4PLS

G4PLS commented May 29, 2025

Copy link
Copy Markdown
Member Author

@G4PLS G4PLS requested a review from Core447 May 29, 2025 16:46
Comment thread src/windows/Store/Icons/IconPage.py Outdated
Comment thread src/windows/Store/Plugins/PluginPage.py Outdated
Comment thread src/windows/Store/Preview.py
Comment thread src/windows/Store/StorePageSection.py
Comment thread src/windows/Store/Wallpapers/WallpaperPage.py Outdated
@G4PLS G4PLS requested a review from ImDevinC May 29, 2025 17:57
@Core447

Core447 commented May 29, 2025

Copy link
Copy Markdown
Member

I'm not yet completely convinced by the design... I get the idea, but I just think it doesn't really fit the GTK style

Also a problem I'm seeing is that the "verified" state is now a SC icon, which works for now, but if we're adding more users to this list in the future, it might be weird

This reverts commit d0b8a61.
@Core447

Core447 commented May 30, 2025

Copy link
Copy Markdown
Member

Reverted the visual changes as the proposed design doesn't fit the GTK style in my opinion.

@G4PLS

G4PLS commented May 30, 2025

Copy link
Copy Markdown
Member Author

@Core447 some things I noticed that you changed back that dont make sense to me:

You removed the whole description change I made on the UI side.
It didnt make a change visually and removed some unneeded boxes

You also changed the cutoff back to what it was but my change there was also working completely fine and just allowing a little bit more space for the short description

Personally I liked the Icons a lot more than the big Text Buttons but as long as the other more important changes stay im fine with it (Meaning mostly the search improvements)

@Core447

Core447 commented May 30, 2025

Copy link
Copy Markdown
Member

@G4PLS
Didn't meant to revert the description and cutoff change(s). I just did a git revert with some hashes, and I probably did a mistake there or some mistake during merge. Sorry about that.

Can reapply e065242 and ecb4429 if those are the (only) ones I accidentally reverted.

@G4PLS

G4PLS commented May 30, 2025

Copy link
Copy Markdown
Member Author

Yeah you only accidentally reverted those two

@G4PLS

G4PLS commented May 30, 2025

Copy link
Copy Markdown
Member Author

But instead of compeltely reverthing the UI changes could we make them smaller?

image
Something in that direction maybe?

My biggest issue is that its just so much wasted space as we only have those 2 badges atm

@G4PLS

G4PLS commented Jun 2, 2025

Copy link
Copy Markdown
Member Author

Trying for this design to be more in line with the GTK Style
image

@G4PLS

G4PLS commented Jun 3, 2025

Copy link
Copy Markdown
Member Author

@Core447 @ImDevinC I have now reworked the UI to be more in line with GTK and added proper translations to the Labels and tooltips. If you want you can now review the changes again.
If there is anything to be changed I will take a look at it.

This is now the new UI of the Plugin page, the Icons and Wallpapers look the same but with changed tooltips to match the Tab that were on.
image

@G4PLS

G4PLS commented Jun 4, 2025

Copy link
Copy Markdown
Member Author

The changes in 150591a was done because I noticed that my Thumbnail was getting cut of by a little bit on the top/bottom.

All thumbnails should follow the 1000x360 resolution so we should make sure that everything from the image is getting shown to the user for a clean user experience

@G4PLS

G4PLS commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

@Core447 whats the status on this?

@Core447 Core447 merged commit 809c660 into StreamController:main Dec 30, 2025
@Core447

Core447 commented Dec 30, 2025

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants