Fixed get_asset_path in ActionBase by G4PLS · Pull Request #263 · StreamController/StreamController · GitHub
Skip to content

Fixed get_asset_path in ActionBase#263

Merged
Core447 merged 1 commit into
StreamController:devfrom
G4PLS:get_asset_path_fix
Oct 26, 2024
Merged

Fixed get_asset_path in ActionBase#263
Core447 merged 1 commit into
StreamController:devfrom
G4PLS:get_asset_path_fix

Conversation

@G4PLS

@G4PLS G4PLS commented Oct 22, 2024

Copy link
Copy Markdown
Member

With subdirs: list[str] = [] the possibility was that modifying the subdirs list could persist. Using None is overall the better option when wanting a List as a param.

@Core447

Core447 commented Oct 26, 2024

Copy link
Copy Markdown
Member

@Core447 Core447 merged commit 5f1d78b into StreamController:dev Oct 26, 2024
@G4PLS G4PLS deleted the get_asset_path_fix branch November 14, 2024 10:48
Core447 added a commit that referenced this pull request Nov 16, 2024
@Core447 @G4PLS
@dependabot @wanderboessenkool @AdiHarif @sifmelcara
1.5.0-beta.7 Release (#280)
0bd2f0f 
* Added Image Layering to ActionBase (#205)

* Feat(ImageLayering): Added Image layering for Buttons

* Feat(ActionBase): Changed method name to be more appropriate for the feature

* Feat(ActionBase): Added get_asset_path to make it easier to get the full path for an asset

* Feat(ImageLayer): Added method to combine image Layers into a full ImageLayer list

* Feat(ImageLayer): Added some helper methods that make Creation of the final image easier

* Feat(ImageLayer): Added some logging to the ImageLayer.

Now Also Skipping layers when they are None

* Refactor(ImageLayer): Changed the methods behaviour slightly to be more accurate to the name. Updated docs accordingly

* Refactor(ImageLayer): Changed things into a Media and Layer class that will be used independent from each other

* Fix(Media): get_final_media had errors because the last image didnt get created correctly

* Feat(Media): Added method to create a Media with an image directly added to it

* Refactor(ActionBase): Removed set_layered_images because this method is not needed with the new approach

* Feat(Media): Added parameter checking

* Feat(Media): Added errors to parameter checks

* Refactor(Media): Removed for loop from add_layer because this is not needed at all

* Chore(MediaLayers): Small adjustments to typing, docstrings and method names

---------

Co-authored-by: Core447 <100139110+Core447@users.noreply.github.com>

* Fix(mainWindow): Showing "no decks available" in header when no pages

* Add support for the sd-neo

Squashed commit of the following:

commit 6bd5ffd
Author: Core447 <100139110+Core447@users.noreply.github.com>
Date:   Sat Sep 21 09:29:07 2024 +0200

    Feat: Add new_enumerate info log

commit 76ec759
Author: Core447 <100139110+Core447@users.noreply.github.com>
Date:   Sat Sep 21 09:23:24 2024 +0200

    Fix: Not using new_enumerate with neo patch

commit 1e717ed
Author: Core447 <100139110+Core447@users.noreply.github.com>
Date:   Tue Sep 10 07:56:04 2024 +0200

    Feat: Add basic sd-neo support via patcher WIP

* Chore(deps): Bump nltk from 3.8.1 to 3.9 (#209)

Bumps [nltk](https://github.com/nltk/nltk) from 3.8.1 to 3.9.
- [Changelog](https://github.com/nltk/nltk/blob/develop/ChangeLog)
- [Commits](nltk/nltk@3.8.1...3.9)

---
updated-dependencies:
- dependency-name: nltk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Build(deps): Bump certifi from 2024.2.2 to 2024.7.4 (#155)

Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.2.2 to 2024.7.4.
- [Commits](certifi/python-certifi@2024.02.02...2024.07.04)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update requirements.txt

* Move to Gnome 47 runtime (#258)

* Move to Gnome 47 runtime

* Merged dev into gnome47-runtime

---------

Co-authored-by: Core447 <100139110+Core447@users.noreply.github.com>

* Update pypi-requirements.yaml

* Chore(StoreBackend): Add official store branch info log

* Bump version to 1.5.0-beta.7

* Update release notes

* Chore: Add sd neo support to readmes

* Fixes a typo in contribution section of README file (#262)

* Feat: Add gsk warning

* Chore: Fix typo in release notes

* Chore: Reformat changelog

* Chore: Add release to metainfo

* Fix(ActionBase): Fixed using empty list in param for get_asset_path (#263)

* Feat(SearchComboRow): Added new ComboRow with integrated Search, useful for big lists (#266)

* Refactor: Move action permission methods into ActionPermissionManager class

* Fix(BackgroundEditor): Not correctly restoring transparent colors

* Feat: Add proper background permission management

* Fix: Icon preview not updating under runtime 47

* Add Stream Deck NEO to udev.rules (#269)

* Fix(SearchComboRow): Changed instances of ComboRowSearchItem to SearchComboRowItem (#267)

* Fix(SearchComboRow): Changed instances of ComboRowSearchItem to SearchComboRowItem because that was forgotten

* Fix(SearchComboRow): Added ability to set the selected item and made the selected item index be emitted as well when the item changes

* Fix: Horizontal background tile gap too small on SD+

* Fix: Give first action background-control permission per default

* Revert "feat: add ability to use line breaks in labels (#147)" because of instability. The revert will be reverted for the .8 release

This reverts commit 536786e.

* Fix: on_update may be called before on_ready

* Feat(Locales): Updated PluginBase and LocaleManager for minor improvements (#271)

* Feat(LocaleManager): Made Plugin still be able to load if locale is not being found

* Feat(PluginBase): Updated locale_manager to either use legacy or new LocaleManager by adding two new args to the __init__

* Refactor(PluginBase): Changed use_legacy_locale from False to True as default

* Fix: Loading action objects of inputs that don't exists on deck

* Fix(ActionConfigurator): UI not getting hidden properly (#275)

* Fix(ActionConfigurator): ConfigGroup and CustomConfig weren't properly hidden when methods are not present

* Fix(ActionConfigurator): Hiding 2nd Seperator when only the CustomConfig is present

* Fix(ActionConfigurator): Correctly hiding when rows are empty and when custom area is none

* Refactor(ActionConfigurator): Changed the way the separator gets hidden

* Fix: Unnecessary 2nd call of get_config_rows()

---------

Co-authored-by: Core447 <100139110+Core447@users.noreply.github.com>

* Remove sd neo patcher

* Fix: Old sd neo patch import

* Chore: Remove old debug prints

* Update requirements

* Chore: Update changelog

* Feat(GtkHelper): Added a better disconnect function because adding try blocks to every ui element is tedious and to much boilerplate (#277)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: GAPLS <125091918+G4PLS@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: wanderboessenkool <31434459+wanderboessenkool@users.noreply.github.com>
Co-authored-by: AdiHarif <49525904+AdiHarif@users.noreply.github.com>
Co-authored-by: Ming-Chuan <10496191+sifmelcara@users.noreply.github.com>
Core447 added a commit that referenced this pull request Nov 16, 2024
@Core447 @G4PLS
@dependabot @wanderboessenkool @AdiHarif @sifmelcara
Small changes for 1.5.0-beta.7 Release (#281)
45b5bc7 
* Added Image Layering to ActionBase (#205)

* Feat(ImageLayering): Added Image layering for Buttons

* Feat(ActionBase): Changed method name to be more appropriate for the feature

* Feat(ActionBase): Added get_asset_path to make it easier to get the full path for an asset

* Feat(ImageLayer): Added method to combine image Layers into a full ImageLayer list

* Feat(ImageLayer): Added some helper methods that make Creation of the final image easier

* Feat(ImageLayer): Added some logging to the ImageLayer.

Now Also Skipping layers when they are None

* Refactor(ImageLayer): Changed the methods behaviour slightly to be more accurate to the name. Updated docs accordingly

* Refactor(ImageLayer): Changed things into a Media and Layer class that will be used independent from each other

* Fix(Media): get_final_media had errors because the last image didnt get created correctly

* Feat(Media): Added method to create a Media with an image directly added to it

* Refactor(ActionBase): Removed set_layered_images because this method is not needed with the new approach

* Feat(Media): Added parameter checking

* Feat(Media): Added errors to parameter checks

* Refactor(Media): Removed for loop from add_layer because this is not needed at all

* Chore(MediaLayers): Small adjustments to typing, docstrings and method names

---------

Co-authored-by: Core447 <100139110+Core447@users.noreply.github.com>

* Fix(mainWindow): Showing "no decks available" in header when no pages

* Add support for the sd-neo

Squashed commit of the following:

commit 6bd5ffd
Author: Core447 <100139110+Core447@users.noreply.github.com>
Date:   Sat Sep 21 09:29:07 2024 +0200

    Feat: Add new_enumerate info log

commit 76ec759
Author: Core447 <100139110+Core447@users.noreply.github.com>
Date:   Sat Sep 21 09:23:24 2024 +0200

    Fix: Not using new_enumerate with neo patch

commit 1e717ed
Author: Core447 <100139110+Core447@users.noreply.github.com>
Date:   Tue Sep 10 07:56:04 2024 +0200

    Feat: Add basic sd-neo support via patcher WIP

* Chore(deps): Bump nltk from 3.8.1 to 3.9 (#209)

Bumps [nltk](https://github.com/nltk/nltk) from 3.8.1 to 3.9.
- [Changelog](https://github.com/nltk/nltk/blob/develop/ChangeLog)
- [Commits](nltk/nltk@3.8.1...3.9)

---
updated-dependencies:
- dependency-name: nltk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Build(deps): Bump certifi from 2024.2.2 to 2024.7.4 (#155)

Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.2.2 to 2024.7.4.
- [Commits](certifi/python-certifi@2024.02.02...2024.07.04)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update requirements.txt

* Move to Gnome 47 runtime (#258)

* Move to Gnome 47 runtime

* Merged dev into gnome47-runtime

---------

Co-authored-by: Core447 <100139110+Core447@users.noreply.github.com>

* Update pypi-requirements.yaml

* Chore(StoreBackend): Add official store branch info log

* Bump version to 1.5.0-beta.7

* Update release notes

* Chore: Add sd neo support to readmes

* Fixes a typo in contribution section of README file (#262)

* Feat: Add gsk warning

* Chore: Fix typo in release notes

* Chore: Reformat changelog

* Chore: Add release to metainfo

* Fix(ActionBase): Fixed using empty list in param for get_asset_path (#263)

* Feat(SearchComboRow): Added new ComboRow with integrated Search, useful for big lists (#266)

* Refactor: Move action permission methods into ActionPermissionManager class

* Fix(BackgroundEditor): Not correctly restoring transparent colors

* Feat: Add proper background permission management

* Fix: Icon preview not updating under runtime 47

* Add Stream Deck NEO to udev.rules (#269)

* Fix(SearchComboRow): Changed instances of ComboRowSearchItem to SearchComboRowItem (#267)

* Fix(SearchComboRow): Changed instances of ComboRowSearchItem to SearchComboRowItem because that was forgotten

* Fix(SearchComboRow): Added ability to set the selected item and made the selected item index be emitted as well when the item changes

* Fix: Horizontal background tile gap too small on SD+

* Fix: Give first action background-control permission per default

* Revert "feat: add ability to use line breaks in labels (#147)" because of instability. The revert will be reverted for the .8 release

This reverts commit 536786e.

* Fix: on_update may be called before on_ready

* Feat(Locales): Updated PluginBase and LocaleManager for minor improvements (#271)

* Feat(LocaleManager): Made Plugin still be able to load if locale is not being found

* Feat(PluginBase): Updated locale_manager to either use legacy or new LocaleManager by adding two new args to the __init__

* Refactor(PluginBase): Changed use_legacy_locale from False to True as default

* Fix: Loading action objects of inputs that don't exists on deck

* Fix(ActionConfigurator): UI not getting hidden properly (#275)

* Fix(ActionConfigurator): ConfigGroup and CustomConfig weren't properly hidden when methods are not present

* Fix(ActionConfigurator): Hiding 2nd Seperator when only the CustomConfig is present

* Fix(ActionConfigurator): Correctly hiding when rows are empty and when custom area is none

* Refactor(ActionConfigurator): Changed the way the separator gets hidden

* Fix: Unnecessary 2nd call of get_config_rows()

---------

Co-authored-by: Core447 <100139110+Core447@users.noreply.github.com>

* Remove sd neo patcher

* Fix: Old sd neo patch import

* Chore: Remove old debug prints

* Update requirements

* Chore: Update changelog

* Feat(GtkHelper): Added a better disconnect function because adding try blocks to every ui element is tedious and to much boilerplate (#277)

* Fix: Weblinks not opening on Flatpak

* Feat: Add donation dialog

* Fix: Donate entry of hamburger menu not working

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: GAPLS <125091918+G4PLS@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: wanderboessenkool <31434459+wanderboessenkool@users.noreply.github.com>
Co-authored-by: AdiHarif <49525904+AdiHarif@users.noreply.github.com>
Co-authored-by: Ming-Chuan <10496191+sifmelcara@users.noreply.github.com>
Core447 added a commit that referenced this pull request Feb 27, 2025
@Core447
Merge main into dev
4fadab2 
commit 775eb66
Author: Astrid <177126746+SilentSwordmaiden@users.noreply.github.com>
Date:   Thu Feb 27 15:41:20 2025 +0100

    only return usb devices made by elgato (#344)

    if a pc has a lot of usb devices attached the query for all of them was very slow.

    we can filter it by only listing devices made by elgate and then check the (hopefully smaller) list for the actual products.

commit cdc2a26
Author: jfbauer432 <57913504+jfbauer432@users.noreply.github.com>
Date:   Sun Jan 12 05:38:32 2025 -0500

    Enable flatpak/install.sh to create from local repo (#216)

    Changed the flatpak/install.sh to it can be used to create
    a flatpak from a source other then the official repo on github.
    Also optionally create a flatpak bundle (can be used to test
    flatpak on another system).

    Added a few options:
      -h --help             Show this message
      --repo=path           Path to StreamController repo (must be local)
                            use 'current' for git repo in current pwd
      --branch=branch       Name of branch in --repo to use
                            Ignored if --repo is not specified
      --make-bundle         Create a flatpak bundle so you can try
                            it on another system
      --yes                 Answer yes to all questions

    Simplified the question answering code

commit 22190cd
Author: Dixon T E <dixonte+github@stc-networks.com>
Date:   Tue Dec 24 02:06:27 2024 +1100

    Using --change-page argument no longer pops up main window (#287)

commit f4ed290
Author: Joe Goett <jgoett154@gmail.com>
Date:   Mon Dec 23 09:01:59 2024 -0500

    Improve window grabber support for swaywm (#289)

commit 45b5bc7
Author: Core447 <100139110+Core447@users.noreply.github.com>
Date:   Sat Nov 16 19:52:44 2024 +0100

    Small changes for 1.5.0-beta.7 Release (#281)

    * Added Image Layering to ActionBase (#205)

    * Feat(ImageLayering): Added Image layering for Buttons

    * Feat(ActionBase): Changed method name to be more appropriate for the feature

    * Feat(ActionBase): Added get_asset_path to make it easier to get the full path for an asset

    * Feat(ImageLayer): Added method to combine image Layers into a full ImageLayer list

    * Feat(ImageLayer): Added some helper methods that make Creation of the final image easier

    * Feat(ImageLayer): Added some logging to the ImageLayer.

    Now Also Skipping layers when they are None

    * Refactor(ImageLayer): Changed the methods behaviour slightly to be more accurate to the name. Updated docs accordingly

    * Refactor(ImageLayer): Changed things into a Media and Layer class that will be used independent from each other

    * Fix(Media): get_final_media had errors because the last image didnt get created correctly

    * Feat(Media): Added method to create a Media with an image directly added to it

    * Refactor(ActionBase): Removed set_layered_images because this method is not needed with the new approach

    * Feat(Media): Added parameter checking

    * Feat(Media): Added errors to parameter checks

    * Refactor(Media): Removed for loop from add_layer because this is not needed at all

    * Chore(MediaLayers): Small adjustments to typing, docstrings and method names

    ---------

    Co-authored-by: Core447 <100139110+Core447@users.noreply.github.com>

    * Fix(mainWindow): Showing "no decks available" in header when no pages

    * Add support for the sd-neo

    Squashed commit of the following:

    commit 6bd5ffd
    Author: Core447 <100139110+Core447@users.noreply.github.com>
    Date:   Sat Sep 21 09:29:07 2024 +0200

        Feat: Add new_enumerate info log

    commit 76ec759
    Author: Core447 <100139110+Core447@users.noreply.github.com>
    Date:   Sat Sep 21 09:23:24 2024 +0200

        Fix: Not using new_enumerate with neo patch

    commit 1e717ed
    Author: Core447 <100139110+Core447@users.noreply.github.com>
    Date:   Tue Sep 10 07:56:04 2024 +0200

        Feat: Add basic sd-neo support via patcher WIP

    * Chore(deps): Bump nltk from 3.8.1 to 3.9 (#209)

    Bumps [nltk](https://github.com/nltk/nltk) from 3.8.1 to 3.9.
    - [Changelog](https://github.com/nltk/nltk/blob/develop/ChangeLog)
    - [Commits](nltk/nltk@3.8.1...3.9)

    ---
    updated-dependencies:
    - dependency-name: nltk
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

    * Build(deps): Bump certifi from 2024.2.2 to 2024.7.4 (#155)

    Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.2.2 to 2024.7.4.
    - [Commits](certifi/python-certifi@2024.02.02...2024.07.04)

    ---
    updated-dependencies:
    - dependency-name: certifi
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

    * Update requirements.txt

    * Move to Gnome 47 runtime (#258)

    * Move to Gnome 47 runtime

    * Merged dev into gnome47-runtime

    ---------

    Co-authored-by: Core447 <100139110+Core447@users.noreply.github.com>

    * Update pypi-requirements.yaml

    * Chore(StoreBackend): Add official store branch info log

    * Bump version to 1.5.0-beta.7

    * Update release notes

    * Chore: Add sd neo support to readmes

    * Fixes a typo in contribution section of README file (#262)

    * Feat: Add gsk warning

    * Chore: Fix typo in release notes

    * Chore: Reformat changelog

    * Chore: Add release to metainfo

    * Fix(ActionBase): Fixed using empty list in param for get_asset_path (#263)

    * Feat(SearchComboRow): Added new ComboRow with integrated Search, useful for big lists (#266)

    * Refactor: Move action permission methods into ActionPermissionManager class

    * Fix(BackgroundEditor): Not correctly restoring transparent colors

    * Feat: Add proper background permission management

    * Fix: Icon preview not updating under runtime 47

    * Add Stream Deck NEO to udev.rules (#269)

    * Fix(SearchComboRow): Changed instances of ComboRowSearchItem to SearchComboRowItem (#267)

    * Fix(SearchComboRow): Changed instances of ComboRowSearchItem to SearchComboRowItem because that was forgotten

    * Fix(SearchComboRow): Added ability to set the selected item and made the selected item index be emitted as well when the item changes

    * Fix: Horizontal background tile gap too small on SD+

    * Fix: Give first action background-control permission per default

    * Revert "feat: add ability to use line breaks in labels (#147)" because of instability. The revert will be reverted for the .8 release

    This reverts commit 536786e.

    * Fix: on_update may be called before on_ready

    * Feat(Locales): Updated PluginBase and LocaleManager for minor improvements (#271)

    * Feat(LocaleManager): Made Plugin still be able to load if locale is not being found

    * Feat(PluginBase): Updated locale_manager to either use legacy or new LocaleManager by adding two new args to the __init__

    * Refactor(PluginBase): Changed use_legacy_locale from False to True as default

    * Fix: Loading action objects of inputs that don't exists on deck

    * Fix(ActionConfigurator): UI not getting hidden properly (#275)

    * Fix(ActionConfigurator): ConfigGroup and CustomConfig weren't properly hidden when methods are not present

    * Fix(ActionConfigurator): Hiding 2nd Seperator when only the CustomConfig is present

    * Fix(ActionConfigurator): Correctly hiding when rows are empty and when custom area is none

    * Refactor(ActionConfigurator): Changed the way the separator gets hidden

    * Fix: Unnecessary 2nd call of get_config_rows()

    ---------

    Co-authored-by: Core447 <100139110+Core447@users.noreply.github.com>

    * Remove sd neo patcher

    * Fix: Old sd neo patch import

    * Chore: Remove old debug prints

    * Update requirements

    * Chore: Update changelog

    * Feat(GtkHelper): Added a better disconnect function because adding try blocks to every ui element is tedious and to much boilerplate (#277)

    * Fix: Weblinks not opening on Flatpak

    * Feat: Add donation dialog

    * Fix: Donate entry of hamburger menu not working

    ---------

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: GAPLS <125091918+G4PLS@users.noreply.github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: wanderboessenkool <31434459+wanderboessenkool@users.noreply.github.com>
    Co-authored-by: AdiHarif <49525904+AdiHarif@users.noreply.github.com>
    Co-authored-by: Ming-Chuan <10496191+sifmelcara@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Dev
Status: Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@G4PLS @Core447