{{ message }}
Housekeeping: keep page backups for one week at most#195
Merged
Conversation
gensyn
changed the title
Member
Contributor
Author
|
To be honest, I was a little confused by which backups were created where. As long as it works now I'm fine. Code looks good. |
Contributor
Author
|
But you are just keeping a fixed number of backups, right? No check for the age of a backup? |
Member
Yes, what is the advantage of checking the age? In theory only keeping one backup should be enough, but just to be sure I set it to 5 (+1). |
Contributor
Author
|
Well, you suggested one week as a time period when we talked about it on Discord so I just went with it since it's definitely better than the status quo. But it's even better now so I'm all for merging. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the backup count for pages quickly rises (I have deleted several hundred backup folders; power users probably have more), I have added a mechanism to clean them up. Backup folders are now deleted after one week - but at least three backup folders are always kept.