Add ipv6 handling and allow non local hosts by caesarakalaeii · Pull Request #30 · StreamController/OBSPlugin · GitHub
Skip to content

Add ipv6 handling and allow non local hosts#30

Open
caesarakalaeii wants to merge 5 commits into
StreamController:mainfrom
caesarakalaeii:feat/ipv6
Open

Add ipv6 handling and allow non local hosts#30
caesarakalaeii wants to merge 5 commits into
StreamController:mainfrom
caesarakalaeii:feat/ipv6

Conversation

@caesarakalaeii

Copy link
Copy Markdown

This PR allows connection to non local hosts and enables ipv6 handling.

Comment thread backend/OBSController.py Outdated
@ImDevinC

Copy link
Copy Markdown

@caesarakalaeii

Copy link
Copy Markdown
Author

I just used black in the default config, but yeah i can revert that 👍

This reverts commit bb988f5.
@caesarakalaeii

Copy link
Copy Markdown
Author

and regarding the dns call, that was just the easiest fix, if you want i can change it to if not (self.validate_ip(host) or self.validate_dns(host)): but unsure if that is any better

@oparada1988

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants