{{ message }}
Repository navigation
Conversation
- using qHash(englishName, 0)
gzotti
added
enhancement
|
Hello @gzotti! Thank you for the suggested improvement. |
Member
|
How many objects in your ssystem.ini files and how many increases performance? |
Member
Author
|
I have started editing about 2 hours ago and wrote "EXPERIMENTAL DRAFT, ignore!" above. If VTune was right, 15-20% of SolarSystem::draw() goes into string equality tests with a solar system of around 11.000 objects. |
This comment was marked as outdated.
This comment was marked as outdated.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXPERIMENTAL DRAFT, ignore!
VTune indicates that a considerable percentage of frame time is string comparison in the solar system, i.e., comparing englishName. This branch tries to mitigate the situation, first by using a hash-based ID.
Description
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: