{{ message }}
Repository navigation
Conversation
pull-request-size
Bot
added
the
size/XS
Member
Member
|
Would you look at adding some unit tests for You can look at the other files under tests/unit/ to see how we've tested other features. The tests will be a good way to show examples of how making the configs templatable could be used. In particular I want to make sure something with a more complex template (maybe a range loop?) will render and get indented correctly. I wonder if we'll need to loop over each entry in |
jk464
force-pushed
the
feature/pack-config-templating
branch
from
May 8, 2024 14:35
9f4b1bc to
5acc4c4
Compare
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says on the tin.
Allows the use of go templating in the
st2.packs.configsvalue when creating the Configs ConfigMap