Add RBAC to action-alias help api. by nzlosh · Pull Request #6022 · StackStorm/st2 · GitHub
Skip to content

Add RBAC to action-alias help api. - #6022

Merged
nzlosh merged 1 commit into
StackStorm:masterfrom
nzlosh:st2help_rbac
Oct 10, 2026
Merged

Add RBAC to action-alias help api.#6022
nzlosh merged 1 commit into
StackStorm:masterfrom
nzlosh:st2help_rbac

Conversation

@nzlosh

@nzlosh nzlosh commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@pull-request-size pull-request-size Bot added the size/M PR that changes 30-99 lines. Good size to review. label Sep 14, 2023
@nzlosh
nzlosh marked this pull request as draft September 14, 2023 20:40
@nzlosh
nzlosh force-pushed the st2help_rbac branch 2 times, most recently from e969b44 to 5d710f3 Compare September 14, 2023 21:00
@nzlosh nzlosh added this to the 3.9.0 milestone Sep 14, 2023
@nzlosh
nzlosh force-pushed the st2help_rbac branch 4 times, most recently from 95ca54e to 781a03d Compare September 15, 2023 05:55
cognifloyd
cognifloyd reviewed Oct 24, 2023
View reviewed changes

@cognifloyd cognifloyd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These st2-specific x-* keys are odd.

Comment thread st2common/st2common/openapi.yaml.j2

@cognifloyd cognifloyd Oct 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see x-permissions above. I wonder why that isn't triggering the permission check.

@nzlosh

nzlosh commented Nov 18, 2023

Copy link
Copy Markdown
Contributor Author

@cognifloyd You're right, the x-parameters aren't required. RBAC is being applied to the help/match endpoints using x-permission. Closing this PR as redundant.

@nzlosh nzlosh closed this Nov 18, 2023
@nzlosh

nzlosh commented Nov 18, 2023

Copy link
Copy Markdown
Contributor Author

@nzlosh nzlosh reopened this Nov 18, 2023
@nzlosh
nzlosh force-pushed the st2help_rbac branch 2 times, most recently from 3f46cab to d964dcf Compare November 18, 2023 10:37
@pull-request-size pull-request-size Bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/M PR that changes 30-99 lines. Good size to review. labels Nov 18, 2023
@arm4b arm4b mentioned this pull request Dec 11, 2023
Merged
@nzlosh
nzlosh force-pushed the st2help_rbac branch 2 times, most recently from ff55640 to 6b95e99 Compare December 21, 2023 10:01
@nzlosh
nzlosh marked this pull request as ready for review December 21, 2023 10:43
@pull-request-size pull-request-size Bot added size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Oct 8, 2026
@pull-request-size pull-request-size Bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several. labels Oct 8, 2026
@nzlosh nzlosh modified the milestones: 3.9.0, 3.10.0 Oct 8, 2026
@nzlosh
nzlosh requested review from skiedude and removed request for amanda11 October 8, 2026 21:14
@nzlosh
nzlosh enabled auto-merge (squash) October 8, 2026 22:44
@nzlosh
nzlosh merged commit 17deb6f into StackStorm:master Oct 10, 2026
64 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in StackStorm v3.9.0 Oct 10, 2026
@nzlosh
nzlosh deleted the st2help_rbac branch October 10, 2026 04:43
@nzlosh nzlosh mentioned this pull request Oct 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cognifloyd cognifloyd cognifloyd left review comments
@skiedude skiedude skiedude approved these changes
@guzzijones guzzijones guzzijones approved these changes

Assignees

No one assigned

Labels

size/S PR that changes 10-29 lines. Very easy to review.

Projects

StackStorm v3.9.0
Status: Done

Milestone

3.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nzlosh @cognifloyd @skiedude @guzzijones