Add multiple login support, fix Google-related login issues by tms · Pull Request #72 · StackExchange/StackExchange.DataExplorer · GitHub
Skip to content

Add multiple login support, fix Google-related login issues #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tms wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add multiple login support, fix Google-related login issues #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1bfbe6f
Rename UserOpenIds to the more-generic UserAuthClaims
tms Aug 23, 2015
08ebe49
Unify login logic so Google OAuth checks agains UserAuthClaims, Users…
tms Aug 24, 2015
6698bd8
Allow upgrading from legacy Google OpenID identifiers, add display (e…
tms Aug 30, 2015
5160eaf
Prevent #tabs from being duplicated as an ID
tms Aug 31, 2015
7e6cbaa
Add list of user logins, start cleaning up profile layout
tms Aug 31, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions App/StackExchange.DataExplorer.Tests/Models/TestQueryExecutions.cs
View file
Open in desktop
27 changes: 4 additions & 23 deletions App/StackExchange.DataExplorer.Tests/Models/TestUser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,32 +12,13 @@ namespace StackExchange.DataExplorer.Tests.Models {

[TestClass]
public class TestUser : BaseTest {

[TestMethod]
public void TestUserCreationSetsCreationDate() {
var u = User.CreateUser("Fred", "a@a.com", "xyz");
Assert.IsNotNull(u.CreationDate);
}

[TestMethod]
public void TestBasicUserCreation() {

User.CreateUser("Fred", "a@a.com", "xyz");

var u2 = Current.DB.Query<User>("select * from Users where Login = @Login", new {Login = "Fred"}).First();
Assert.AreEqual("Fred", u2.Login);

var o = Current.DB.Query<UserOpenId>("select * from UserOpenIds where OpenIdClaim = @claim", new {claim = "xyz"}).FirstOrDefault();
Assert.AreEqual("xyz", o.OpenIdClaim);
}

[TestMethod]
public void TestNoName() {

Current.DB.Execute("delete from Users where Login like 'jon.doe%'");

var u1 = User.CreateUser("", null, "xyz");
var u2 = User.CreateUser(null, "", "xyz1");
var u1 = User.CreateUser("", null);
var u2 = User.CreateUser(null, "");

Assert.AreEqual("jon.doe", u1.Login);
// This behaviour is probably not what we want
Expand All @@ -49,13 +30,13 @@ public void TestNoSpaces() {

Current.DB.Execute("delete from Users where Login like 'jon.doe%'");

var u1 = User.CreateUser("jon doe", null, "xyz");
var u1 = User.CreateUser("jon doe", null);
Assert.AreEqual("jon.doe", u1.Login);
}

[TestMethod]
public void TestWeirdChars() {
var u1 = User.CreateUser("jon&*doe", null, "xyz");
var u1 = User.CreateUser("jon&*doe", null);
Assert.AreEqual(u1.Login, "jondoe");
}
}
Expand Down
6 changes: 6 additions & 0 deletions App/StackExchange.DataExplorer/App_Start/BundleConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,15 @@ private static void RegisterBundles(BundleCollection bundles)
.Include("~/Content/homepage.css")
.Include("~/Content/topbar.css", new CssRewriteUrlTransform())
.Include("~/Content/header.css", new CssRewriteUrlTransform())
.Include("~/Content/user.css")
.Include("~/Content/jquery.autocomplete.css")
);

bundles.Add(new StyleBundle("~/assets/css/login")
.Include("~/Content/login.css", new CssRewriteUrlTransform())
.Include("~/Content/login-providers.css", new CssRewriteUrlTransform())
);

bundles.Add(new StyleBundle("~/assets/css/query")
.Include("~/Content/codemirror/codemirror.css")
.Include("~/Content/codemirror/custom.css")
Expand Down
8 changes: 4 additions & 4 deletions App/StackExchange.DataExplorer/Content/header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,15 @@ nav.primary .site-selector-popup .ac_results li.ac_over {
margin-bottom: 0;
}

#tabs {
.nav-tabs {
float: right;
}

.miniTabs {
margin-left: 5px;
}

#tabs a, .miniTabs a {
.nav-tabs a, .miniTabs a {
background:none repeat scroll 0 0 #fff;
border: 1px solid #fff;
color: #777;
Expand All @@ -152,7 +152,7 @@ nav.primary .site-selector-popup .ac_results li.ac_over {
text-decoration: none;
}

#tabs a:hover, .miniTabs a:hover {
.nav-tabs a:hover, .miniTabs a:hover {
background: none repeat scroll 0 0 #FFFFFF;
border-color: #CCC #CCC #FFFFFF;
border-style: solid;
Expand All @@ -161,7 +161,7 @@ nav.primary .site-selector-popup .ac_results li.ac_over {
margin-top: 9px;
}

#tabs a.youarehere, .miniTabs a.youarehere {
.nav-tabs a.youarehere, .miniTabs a.youarehere {
background: none repeat scroll 0 0 #FFFFFF;
border-color: #CCC #CCC #FFFFFF;
border-style: solid;
Expand Down
8 changes: 8 additions & 0 deletions App/StackExchange.DataExplorer/Content/login-providers.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
.stackexchange { background-position: -356px 0; }
.google { background-position: -426px 0; }
.yahoo { background-position: 1px 4px; }
.livejournal { background-position: -73px 4px; }
.wordpress { background-position: -38px 4px; }
.blogger { background-position: -108px 4px; }
.verisign { background-position: -458px 4px; }
.aol { background-position: -142px 4px; }
104 changes: 104 additions & 0 deletions App/StackExchange.DataExplorer/Content/user.css
View file
Open in desktop
Loading