fix windows build CI by brunoenten · Pull Request #152 · SpotlightKid/python-rtmidi · GitHub
Skip to content

fix windows build CI#152

Merged
brunoenten merged 3 commits into
masterfrom
develop
Jun 12, 2023
Merged

fix windows build CI#152
brunoenten merged 3 commits into
masterfrom
develop

Conversation

@brunoenten

Copy link
Copy Markdown
Collaborator

No description provided.

@brunoenten brunoenten merged commit 8245ca1 into master Jun 12, 2023
Comment thread src/_rtmidi.pyx

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change should warrant a minor version number increase.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's actually usable 'tho

Comment on lines +6 to +9
- improve-build
pull_request:
branches:
- rtmidi-5.0.0
- improve-build

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something doesn't seem right here. Does this belong in the master branch?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this file to test workflow changes. I guess we can delete it now.

@SpotlightKid

Copy link
Copy Markdown
Owner

@brunoenten brunoenten deleted the develop branch June 13, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants