Build wheels using cibuildwheel by Czaki · Pull Request #100 · SpotlightKid/python-rtmidi · GitHub
Skip to content

Build wheels using cibuildwheel#100

Closed
Czaki wants to merge 13 commits into
SpotlightKid:masterfrom
Czaki:cibuildwheel
Closed

Build wheels using cibuildwheel#100
Czaki wants to merge 13 commits into
SpotlightKid:masterfrom
Czaki:cibuildwheel

Conversation

@Czaki

@Czaki Czaki commented Sep 20, 2021

Copy link
Copy Markdown

This PR adds building wheels using cibuildwheel which simplifies creating wheels and adds support for Linux wheels. It also changes macOS wheels from x86_64 to universal2 (to work on m1 machine).

I do not found an option to run tests on CI.

Here sample run https://github.com/Czaki/python-rtmidi/actions/runs/1253787788

@SpotlightKid

Copy link
Copy Markdown
Owner

@ntamas

ntamas commented Dec 3, 2021

Copy link
Copy Markdown

@SpotlightKid Did you have a chance to look at this PR? It would be great to have a new set of wheels on PyPI as Python 3.10 has been released; also, I currently need to compile from source on Apple Silicon. Thanks a lot!

@SpotlightKid

Copy link
Copy Markdown
Owner

@ntamas Not in detail yet, sorry. I'm away for the weekend, but I'll try to look at it next week. At first glance it looks good, though.

@ntamas

ntamas commented Dec 6, 2021

Copy link
Copy Markdown

Thanks! In the meanwhile I tried the PR In my own fork and it seems like it still works nicely and generates correct wheels for Win32, macOS and Linux; see here.

@Czaki

Czaki commented Dec 6, 2021

Copy link
Copy Markdown
Author

Just updated to the last release of cibuildwheel.
Disable musllinux wheels as it fails to detect pthread. I do not know if this check should be performed on musllinux (it may be built-in muslc).

https://github.com/Czaki/python-rtmidi/actions/runs/1545141326

@Bubobubobubobubo

Copy link
Copy Markdown

@SpotlightKid: can we proceed further with the integration of cibuildwheel?
This would greatly simplify the installation process of many rtmidi dependant code bases.

@georgeharker

Copy link
Copy Markdown
Contributor

I'd love to see this in mainline - it fixes issues building for python 3.11

@Czaki Czaki marked this pull request as draft April 19, 2023 07:07
@brunoenten

Copy link
Copy Markdown
Collaborator

Thanks for your contribution. It was probably used to create PR #119, superseding this one.

@brunoenten brunoenten closed this May 21, 2023
@Czaki

Czaki commented May 21, 2023

Copy link
Copy Markdown
Author

As last time I check the #119 was failing so I kept it to make some wheel available for some folks.

If you need help with cibuildwheel feel free to ping

@brunoenten

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants