docs: finalize bug_smoke_studies_data_table_search_flake (#308)#309
Conversation
…eatures (#308) PR #308 merged to main on 2026-05-29 (76a2f24). Finalization: - Move bug_smoke_studies_data_table_search_flake/ → implemented_features/2026_05_29_bug_smoke_studies_data_table_search_flake/ (also corrects bug_fix.md relative links: 4-level is correct at the 4-deep implemented location, vs the 5-deep planned location Gemini saw). - state.md: add prominent ACTIVE CI note (SKIP_HEAVY_CI on until ~2026-06-01); prepend bug #5 to "Last 5 merges", drop oldest (#297). - state_history.md: prepend CI-budget (#307) + bug #5 (#308) entries. - Dashboard regen. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: SoundMindsAI <eric.starr@soundminds.ai>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project's dashboards and state tracking files to reflect the completion of the bug_smoke_studies_data_table_search_flake bug fix and documents the temporary activation of the SKIP_HEAVY_CI budget measure. Feedback is provided regarding a broken relative link to the E2E test file in the moved idea.md file, which has propagated broken links to the generated dashboard files.
There was a problem hiding this comment.
The relative link to studies-data-table.spec.ts is broken (../../../ui/tests/e2e/... instead of ../../ui/tests/e2e/...). This is because the source file idea.md (now at docs/00_overview/implemented_features/2026_05_29_bug_smoke_studies_data_table_search_flake/idea.md) still contains a 5-level deep relative link (../../../../../ui/tests/e2e/...) which was correct when it was in planned_features (5-deep) but is now broken at the 4-deep implemented_features location.\n\nTo fix this, please update the link in idea.md to use 4 levels (../../../../ui/tests/e2e/...) and then run make dashboard to regenerate the dashboard files.
There was a problem hiding this comment.
While the adjudication for bug_fix.md's 4-level links is correct, the 5-level relative link in idea.md (line 26: ../../../../../ui/tests/e2e/studies-data-table.spec.ts#L20-L40) was not updated to a 4-level link (../../../../ui/tests/e2e/...) during the move to implemented_features/ (4-deep). This causes the dashboard generator to produce broken ../../../ links in MVP1_DASHBOARD.md and mvp1_dashboard.html instead of ../../.\n\nPlease update the link in idea.md to use 4 levels and regenerate the dashboards.
1 participant
Summary
Docs-only finalization after #308 merged to main (
76a2f248).bug_smoke_studies_data_table_search_flake/→implemented_features/2026_05_29_bug_smoke_studies_data_table_search_flake/. This also resolves the Gemini link finding on test(e2e): harden studies-data-table search assertion against CI flake #308: the bug_fix.md../../../../(4-level) links were wrong at the 5-deepplanned_featureslocation Gemini reviewed, but are correct at the 4-deepimplemented_featureslocation — verified resolving. (Applying Gemini's 5-level suggestion would have broken them post-move.)state.md: adds a prominent ACTIVE CI note —SKIP_HEAVY_CIkill-switch is on until ~2026-06-01, heavy jobs skipped, lean on local tests before merging. Prepends the bug chore(deps): Bump actions/checkout from 4 to 6 #5 one-liner to "Last 5 merges", drops the oldest (fix(seed-es): retry bulk-index on unavailable_shards_exception #297).state_history.md: prepends the CI-budget (ci(pr): SKIP_HEAVY_CI kill-switch for >1-min jobs (temporary budget measure) #307) + bug chore(deps): Bump actions/checkout from 4 to 6 #5 (test(e2e): harden studies-data-table search assertion against CI flake #308) reasoning entries.state-md-size-guardpasses (state.md = 10.7 KB). No code change.🤖 Generated with Claude Code