iframe-proxy

jdkandersson · 2026-08-19T08:19:15Z

Summary

map Stylelint's CSS rule and stylelint-scss's SCSS-aware rule to css:S4662
target plain CSS and SCSS independently, including embedded style blocks
preserve the shared supported-tool allowlist and configured exclusions across both bindings
keep indented Sass and Less excluded
add rule, targeting, embedded-content, transformer, metadata, mapping, and integration coverage

Verification

clean npm ci without a postcss-sass patch
99 focused rule, targeting, embedded-content, and transformer tests
bridge TypeScript compilation
focused formatting and git diff --check
Maven integration tests not run locally because Maven is unavailable; fast-test fixtures are included for CI

Ruling Report

New issues flagged (1 issue)

S4662

custom-css/S4662.scss:3

     1 | @use 'variables'; /* No FP */
     2 | 
>    3 | @@media {
     4 |  display: none;
     5 | }

Ruling passed with these expected-result updates already present in the branch. No fix PR was needed.

Generated with GitHub Actions

gitar-bot · 2026-08-21T12:01:32Z

      config,
    };

+    await sonarRulesReady;


💡 Edge Case: sonarRulesReady rejection bypasses APIError wrapping

await sonarRulesReady at wrapper.ts:98 sits outside the .catch attached to stylelint.lint(...), so if the module-level ruleReady promise (built from stylelint.rules[UPSTREAM_RULE]) ever rejects, lint() throws a raw error instead of the wrapped APIError.linterError, and the module-level promise can also surface as an unhandled rejection if lint() is never called. This is unlikely for a built-in stylelint rule, but wrapping the await (e.g. try/catch converting to APIError) would keep failure handling consistent.

_{Was this helpful? React with 👍 / 👎}

gitar-bot · 2026-08-21T15:07:51Z

Code Review 👍 Approved with suggestions 2 resolved / 3 findings

Adds SCSS-aware css:S4662 analysis with independent targeting for plain CSS and SCSS, addressing the Sass filter and warning suppression findings. Consider ensuring the sonarRulesReady rejection wraps APIError properly.

💡 Edge Case: sonarRulesReady rejection bypasses APIError wrapping

📄 packages/analysis/src/css/linter/wrapper.ts:98-107 📄 packages/analysis/src/css/rules/S8757/rule.ts:25-27 📄 packages/analysis/src/css/rules/index.ts:28

await sonarRulesReady at wrapper.ts:98 sits outside the .catch attached to stylelint.lint(...), so if the module-level ruleReady promise (built from stylelint.rules[UPSTREAM_RULE]) ever rejects, lint() throws a raw error instead of the wrapped APIError.linterError, and the module-level promise can also surface as an unhandled rejection if lint() is never called. This is unlikely for a built-in stylelint rule, but wrapping the await (e.g. try/catch converting to APIError) would keep failure handling consistent.

✅ 2 resolved

✅ Edge Case: Sass filter suppresses warnings when block source range is incomplete

📄 packages/analysis/src/css/linter/issues/transform.ts:121-135
isOutsideSassEmbeddedBlock returns true (suppress) by default when no embedded block's source range matches the warning position — including the case where a real Sass block has a missing/partial start/end position (isWithinSourceRange returns false). This is the opposite of the CSS-only path (isInNonCssEmbeddedBlock), which keeps the warning in that situation (see the test 'does not suppress warnings when a non-CSS block has no explicit end position'). The result is a potential false negative: a legitimate scss/at-rule-no-unknown issue inside a Sass block could be silently dropped if position metadata is incomplete. Consider defaulting to keep (return false) when no block matches, or add coverage for an incomplete-source Sass block to confirm the intended behavior.

✅ Edge Case: Sass-only warning inside a complete non-Sass block not suppressed

📄 packages/analysis/src/css/linter/issues/transform.ts:148-155
When a Sass block has an incomplete range, isOutsideSassEmbeddedBlock returns !hasSassBlockWithIncompleteRange (false), so the warning is kept even if it definitively fell within a complete non-Sass block (e.g. a css/less block). This can surface a sass-only rule on plain CSS code. It's a conservative tradeoff, but you could suppress precisely by returning true when the warning matches a complete non-Sass block range, before falling back to the incomplete-range guard.

🤖 Prompt for agents

Code Review: Adds SCSS-aware css:S4662 analysis with independent targeting for plain CSS and SCSS, addressing the Sass filter and warning suppression findings. Consider ensuring the sonarRulesReady rejection wraps APIError properly.

1. 💡 Edge Case: sonarRulesReady rejection bypasses APIError wrapping
   Files: packages/analysis/src/css/linter/wrapper.ts:98-107, packages/analysis/src/css/rules/S8757/rule.ts:25-27, packages/analysis/src/css/rules/index.ts:28

   `await sonarRulesReady` at wrapper.ts:98 sits outside the `.catch` attached to `stylelint.lint(...)`, so if the module-level `ruleReady` promise (built from `stylelint.rules[UPSTREAM_RULE]`) ever rejects, `lint()` throws a raw error instead of the wrapped `APIError.linterError`, and the module-level promise can also surface as an unhandled rejection if `lint()` is never called. This is unlikely for a built-in stylelint rule, but wrapping the await (e.g. try/catch converting to APIError) would keep failure handling consistent.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

`Auto-apply`	`Compact`
`gitar auto-apply:on`	`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

sonarqube-next · 2026-08-21T15:21:58Z

gitar-bot Bot reviewed Aug 19, 2026

View reviewed changes

Comment thread packages/analysis/src/css/linter/issues/transform.ts Outdated

This comment has been minimized.

Sign in to view

github-actions Bot mentioned this pull request Aug 19, 2026

Update ruling results for PR #7780 #7782

Closed

JS-2274 Add Sass-aware S4662 analysis

04cfb3e

jdkandersson force-pushed the fix-s4662-sass branch from 4eb465b to 04cfb3e Compare August 19, 2026 09:14

jdkandersson and others added 2 commits August 19, 2026 13:00

JS-2274 Address Sass analysis review feedback

58f493c

Update ruling results

0282aa6

Generated with GitHub Actions

gitar-bot Bot reviewed Aug 19, 2026

View reviewed changes

Comment thread packages/analysis/src/css/linter/issues/transform.ts Outdated

JS-2274 Limit Sass-aware analysis to SCSS

a0e6a31

jdkandersson changed the title ~~JS-2274 Add Sass-aware css:S4662 analysis~~ JS-2274 Add SCSS-aware css:S4662 analysis Aug 19, 2026

github-actions Bot mentioned this pull request Aug 19, 2026

Update ruling results for PR #7780 #7794

Closed

jdkandersson and others added 7 commits August 19, 2026 17:14

JS-2274 Fix generated defaults and embedded routing

5a7e370

Update ruling results

2ae58a8

Generated with GitHub Actions

JS-2274 Fix generated default guard

22b68f7

JS-2274 Simplify SCSS rule activation

283c4c1

JS-2274 Avoid relabeling concurrent CSS warnings

cf941a2

JS-2274 Resolve CSS rule before linting

8b39dea

JS-2274 Initialize CSS rules before linting

365eb2a

gitar-bot Bot reviewed Aug 21, 2026

View reviewed changes

jdkandersson added 3 commits August 21, 2026 14:07

JS-2274 Update SCSS ruling expectation

685ce22

JS-2274 Map SCSS issues to S4662 in plugin

0009968

JS-2274 Simplify CSS rule readiness

d508c28

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

JS-2274 Add SCSS-aware css:S4662 analysis - #7780

JS-2274 Add SCSS-aware css:S4662 analysis#7780
jdkandersson wants to merge 14 commits into
masterfrom
fix-s4662-sass

jdkandersson commented Aug 19, 2026 •

edited by atlassian Bot

Loading

Uh oh!

hashicorp-vault-sonar-prod Bot commented Aug 19, 2026 •

edited by atlassian Bot

Loading

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot commented Aug 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

gitar-bot Bot Aug 21, 2026

Uh oh!

gitar-bot Bot commented Aug 21, 2026

Uh oh!

sonarqube-next Bot commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

jdkandersson commented Aug 19, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Related

Uh oh!

hashicorp-vault-sonar-prod Bot commented Aug 19, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ruling Report

New issues flagged (1 issue)

S4662

Uh oh!

Uh oh!

gitar-bot Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

gitar-bot Bot commented Aug 21, 2026

Uh oh!

sonarqube-next Bot commented Aug 21, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jdkandersson commented Aug 19, 2026 •

edited by atlassian Bot

Loading

hashicorp-vault-sonar-prod Bot commented Aug 19, 2026 •

edited by atlassian Bot

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading