{{ message }}
Matter Switch: Remove Energy Setters in added#2152
Merged
Conversation
Test Results 67 files 440 suites 0s ⏱️ Results for commit 17b2d60. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 17b2d60 |
nickolas-deboom
approved these changes
May 29, 2025
ctowns
reviewed
May 29, 2025
ctowns
approved these changes
May 29, 2025
dljsjr
pushed a commit
that referenced
this pull request
Jun 9, 2025
* remove energy setters from added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove
emit_eventcalls in added. In the case ofpowerMeter, this will be populated with a distinct value aftersubscribeoccurs either indevice_initorinfo_changed. It is the same in the case ofenergyMeter. In both cases, setting an initial value of 0 on added does not add any meaningful data to the capability handling, and so this is a wasted call.Summary of Completed Tests
One test removed related to ensuring this was running.