Add ISM330DHCX by Noxime · Pull Request #158 · SlimeVR/SlimeVR-Rust · GitHub
Skip to content

Add ISM330DHCX#158

Draft
Noxime wants to merge 3 commits into
SlimeVR:mainfrom
Noxime:imu-ism330dhcx
Draft

Add ISM330DHCX#158
Noxime wants to merge 3 commits into
SlimeVR:mainfrom
Noxime:imu-ism330dhcx

Conversation

@Noxime

@Noxime Noxime commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

Probably applicable for other ST micro's IMUs #154

@Noxime Noxime requested a review from TheButlah as a code owner January 25, 2023 21:15
github-advanced-security[bot]
github-advanced-security AI found potential problems Jan 25, 2023
View reviewed changes
Comment thread firmware/src/main.rs

Check warning

Code scanning / clippy

the feature `async_fn_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes

the feature `async_fn_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
Comment thread firmware/src/imu/driver/ism330dhcx.rs
}

impl<I: I2c> Ism330Dhcx<I> {
pub fn new(mut i2c: I) -> Result<Self, <I as I2c>::Error> {

Check warning

Code scanning / clippy

associated function `new` is never used

associated function `new` is never used
@TheButlah

TheButlah commented Jan 25, 2023

Copy link
Copy Markdown
Collaborator

I've not seen this chip before. Do you have one you are using to test?

@Noxime Noxime added the Area: Firmware Relating to the firmware subprojct label Jan 25, 2023
@TheButlah TheButlah added the Type: Enhancement A new feature or improvement label Jan 25, 2023
@TheButlah

TheButlah commented Jan 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

If you don't even have the chip in hand, and didn't even run the code, and its a random IMU I've never anyone talk about in discord, I don't understand why you opened a PR. Marking as a draft until someone can test this on hardware.

@TheButlah TheButlah closed this Jan 26, 2023
@TheButlah TheButlah added Status: Help Wanted Requires help from another person to progress Status: Needs Hardware Requires testing on hardware to progress labels Jan 26, 2023
@TheButlah TheButlah reopened this Jan 26, 2023
@TheButlah TheButlah marked this pull request as draft January 26, 2023 10:02
@TheButlah

TheButlah commented Jan 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I'm going to assume that you acted in good faith and were not trying to spam PRs to prove a point. I'll be drafting up a clarification in the contributing.md making more clear what the bar is for merge. Hopefully that will help avoid these shenanigans in the future.

@Noxime

Noxime commented Jan 26, 2023

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheButlah TheButlah Awaiting requested review from TheButlah TheButlah is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Area: Firmware Relating to the firmware subprojct Status: Help Wanted Requires help from another person to progress Status: Needs Hardware Requires testing on hardware to progress Type: Enhancement A new feature or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Noxime @TheButlah @github-advanced-security