{{ message }}
Repository navigation
fix(cli): declare pyyaml and json5 as base dependencies for skyvern setup/mcp - #8879
Open
li12345678990 wants to merge 1 commit into
Open
li12345678990 wants to merge 1 commit into
li12345678990 wants to merge 1 commit into
Conversation
The MCP docs tell users to `pip install skyvern` and then run `skyvern setup <client>` / `skyvern mcp switch`, but those commands import `yaml` and `json5` at module level, which are only available through the `server` extra. On a base install they fail with a "Missing Dependency" error that asks for `skyvern[server]`. Add both to `project.dependencies` and add a test that checks that the module-level third-party imports reachable from these two CLI modules are base dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
The MCP docs (
docs/snippets/mcp-content.mdx) tell users to runpip install skyvernand thenskyvern setup hermes/openclaw/mcporterorskyvern mcp switch. Both CLI modules import third-party packages at module level that are only installed through theserverextra:skyvern/cli/setup_commands.py:yaml,json5skyvern/cli/mcp_commands.py:yamlSo on a base install (reproduced with the current PyPI release,
skyvern==1.0.55, in a fresh venv) both documented commands stop at:(
skyvern setup hermesreportsMissing: json5.)This PR adds
pyyamlandjson5(same range as the existingserver/localpin) toproject.dependencies. Both are small, pure-Python packages, so the base install stays lightweight.uv.lockis regenerated withuv lock; the diff only adds the two entries.It also adds
tests/unit/test_base_install_cli_dependencies.py, in the style oftest_dependency_python_version_markers.py. The test statically follows the module-level imports ofskyvern.cli.setup_commandsandskyvern.cli.mcp_commands(including theskyvern.*modules they import) and asserts that every third-party package they reach is a base dependency. That way a new top-level import can't silently break the base install again.How Has This Been Tested?
main(skyvern.cli.setup_commands imports ['json5', 'yaml'], which are not in project.dependencies, and the same formcp_commandswith['yaml']) and passes with this change.pytest tests/unit/test_base_install_cli_dependencies.py tests/unit/test_mcp_commands.py tests/unit/test_setup_commands.py tests/unit/test_dependency_python_version_markers.py: 40 passed (env:uv pip install -e .[server]+ dev group, Python 3.12).HOME:skyvern mcp switch --dry-runnow opens the switcher ("No supported MCP client config files were found…"), andskyvern setup hermesgets to the "No API key found. Run skyvern login…" prompt instead of the Missing Dependency error.ruff format --check/ruff checkclean on the new file.This PR was prepared with AI assistance (Claude Code); I reviewed the change and ran the checks above.
🤖 Generated with Claude Code