{{ message }}
Repository navigation
feat(frontend): assign agent folder inline from the Folder column - #8876
Open
swaidhanoa1 wants to merge 2 commits into
Open
swaidhanoa1 wants to merge 2 commits into
swaidhanoa1 wants to merge 2 commits into
Conversation
Make the Folder cell in the agents list a dropdown that opens the existing FolderPickerCommand, so moving an agent to a folder no longer requires the row's actions menu. Shared move/toast logic lives in useMoveWorkflowToFolder. Co-Authored-By: Swai Dhanoa <dhanoaswai@gmail.com>
Co-Authored-By: Swai Dhanoa <dhanoaswai@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Folder column on the Agents list is now an inline dropdown. Click the cell to open the same searchable folder picker (
FolderPickerCommand) the row's "Move to folder" menu uses, then pick a folder (or "Remove from folder") to reassign the agent directly. You no longer have to go through the⋯menu.WorkflowFolderCell(Popover +FolderPickerCommand). Shows the current folder name, or-when unassigned, plus a chevron on row hover. Clicks inside the picker don't bubble to row navigation.WorkflowsFlat.tsx) and the directory-tree row (tree/WorkflowRow.tsx). The Folder cell no longer navigates to runs when clicked; the other cells still do.WorkflowRowActionsintouseMoveWorkflowToFolder, so the context menu and the inline cell behave the same way.How Has This Been Tested?
WorkflowFolderCell.test.tsxcovers: rendering the current folder, assigning a folder, removing from a folder, and checking that picker clicks don't reach row handlers.npx vitest run src/routes/workflows: all suites pass.tsc --noEmit,eslintandprettier --checkare clean.PUT /api/v1/workflows/{wpid}/folderwith{"folder_id":"f2"}and the page stays on/agents.The table looks the same as
mainuntil you hover. On hover, a chevron shows on the right of the Folder cell, and clicking the cell opens the picker. Demo video attached.folder-dropdown-demo.zip