fix(SKY-11217): restore parameter-value search on the v2 runs list by AronPerez · Pull Request #6796 · Skyvern-AI/skyvern · GitHub
Skip to content

fix(SKY-11217): restore parameter-value search on the v2 runs list - #6796

Merged
AronPerez merged 3 commits into
mainfrom
repo-sync/aronperez/SKY-11217/restore-runs-v2-param-search
Jun 24, 2026
Merged

AronPerez merged 3 commits into
mainfrom
repo-sync/aronperez/SKY-11217/restore-runs-v2-param-search

Conversation

@AronPerez

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 24, 2026 21:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores run-history search behavior on the v2 runs list so that searches match agent input values (workflow run parameters + extra HTTP headers) for the common task_runs-backed rows, and adds regression coverage to prevent future regressions.

Changes:

  • Extend get_all_runs_v2 primary task_runs search filter to include correlated EXISTS clauses over workflow_run_parameters and extra_http_headers.
  • Factor the “run input search” predicates into a reusable helper and reuse it in the workflow-runs fallback search.
  • Add a regression unit test for SKY-11217, and add a Vitest afterEach cleanup + macrotask flush to avoid Radix FocusScope teardown timing issues.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/unit/forge/sdk/db/test_workflow_runs_repository.py Adds regression test ensuring v2 primary query matches parameter key/description/value and extra_http_headers without implicitly pulling workflows.title into the query.
skyvern/forge/sdk/db/repositories/workflow_runs.py Reintroduces parameter/header search for the primary v2 task_runs query via a shared, correlated helper used by both primary and fallback queries.
skyvern-frontend/vitest.setup.ts Ensures React Testing Library cleanup and flushes a pending FocusScope setTimeout(…, 0) after each test to avoid teardown cross-realm event dispatch issues.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AronPerez
AronPerez merged commit 842905a into main Jun 24, 2026
11 of 13 checks passed
@AronPerez
AronPerez deleted the repo-sync/aronperez/SKY-11217/restore-runs-v2-param-search branch June 24, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants