{{ message }}
Repository navigation
Pass workflow_permanent_id in TOTP webhook POST body - #4871
Merged
Merged
Conversation
added 2 commits
February 25, 2026 04:19
Synced from cloud PR: https://github.com/Skyvern-AI/skyvern-cloud/pull/8972 Author: @suchintan ## Summary - Fix `poll_otp_value` to forward `workflow_permanent_id` to `_get_otp_value_from_url`, so the TOTP webhook POST body includes it as documented - Add 3 unit tests verifying the `workflow_permanent_id` is included/excluded correctly in the webhook payload and that `poll_otp_value` forwards it end-to-end ## Test plan - [x] All 16 unit tests pass (`pytest tests/unit/test_credential_totp_priority.py -v`) - [x] `py_compile` passes on modified files - [ ] Verify webhook POST body includes `workflow_permanent_id` in staging 🤖 Generated with [Claude Code](https://claude.ai/code)
Synced from cloud PR: https://github.com/Skyvern-AI/skyvern-cloud/pull/8972 Author: @suchintan ## Summary - Fix `poll_otp_value` to forward `workflow_permanent_id` to `_get_otp_value_from_url`, so the TOTP webhook POST body includes it as documented - Add 3 unit tests verifying the `workflow_permanent_id` is included/excluded correctly in the webhook payload and that `poll_otp_value` forwards it end-to-end ## Test plan - [x] All 16 unit tests pass (`pytest tests/unit/test_credential_totp_priority.py -v`) - [x] `py_compile` passes on modified files - [ ] Verify webhook POST body includes `workflow_permanent_id` in staging 🤖 Generated with [Claude Code](https://claude.ai/code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synced from cloud PR: https://github.com/Skyvern-AI/skyvern-cloud/pull/8972
Author: @suchintan
Summary
poll_otp_valueto forwardworkflow_permanent_idto_get_otp_value_from_url, so the TOTP webhook POST body includes it as documentedworkflow_permanent_idis included/excluded correctly in the webhook payload and thatpoll_otp_valueforwards it end-to-endTest plan
pytest tests/unit/test_credential_totp_priority.py -v)py_compilepasses on modified filesworkflow_permanent_idin staging🤖 Generated with Claude Code