Fix rich text cloning and palette cache key by JimBobSquarePants · Pull Request #413 · SixLabors/ImageSharp.Drawing · GitHub
Skip to content

Fix rich text cloning and palette cache key - #413

Merged
JimBobSquarePants merged 2 commits into
mainfrom
js/font-palette
Aug 8, 2026
Merged

JimBobSquarePants merged 2 commits into
mainfrom
js/font-palette

Conversation

@JimBobSquarePants

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Adds missing RichTextRun fields to the RichTextOptions copy constructor, including feature tags, shaping metadata, color font settings, and font palette, so cloned options preserve run behavior correctly. It also includes FontPalette in glyph cache keys to prevent cache collisions between palette variants, and updates SixLabors.Fonts/ImageSharp package versions.

Adds missing RichTextRun fields to the RichTextOptions copy constructor, including feature tags, shaping metadata, color font settings, and font palette, so cloned options preserve run behavior correctly. It also includes FontPalette in glyph cache keys to prevent cache collisions between palette variants, and updates SixLabors.Fonts/ImageSharp package versions.
@JimBobSquarePants JimBobSquarePants added the bug Something isn't working label Aug 8, 2026
@codecov

codecov Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

@JimBobSquarePants
JimBobSquarePants merged commit 9a57bc5 into main Aug 8, 2026
12 checks passed
@JimBobSquarePants
JimBobSquarePants deleted the js/font-palette branch August 10, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant