Handle case when Foreground image overhangs bottom of background image during DrawImage Call (3.1 target) by tocsoft · Pull Request #2610 · SixLabors/ImageSharp · GitHub
Skip to content

Handle case when Foreground image overhangs bottom of background image during DrawImage Call (3.1 target) - #2610

Merged
tocsoft merged 4 commits into
release/3.1.xfrom
issue/2603
Dec 10, 2023
Merged

Handle case when Foreground image overhangs bottom of background image during DrawImage Call (3.1 target)#2610
tocsoft merged 4 commits into
release/3.1.xfrom
issue/2603

Conversation

@tocsoft

@tocsoft tocsoft commented Dec 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Prevents the ArgumentOutOfRangeException when the area of interest of the foreground image will be drawn past the edge of the bounds of the background image.

fixes #2603
related to #2609

Targeting 3.1 release branch

@tocsoft
tocsoft force-pushed the issue/2603 branch 2 times, most recently from 9cced1a to ec55081 Compare December 8, 2023 15:59
@JimBobSquarePants

JimBobSquarePants commented Dec 8, 2023

Copy link
Copy Markdown
Member

@tocsoft

tocsoft commented Dec 8, 2023

Copy link
Copy Markdown
Member Author

👍 i'll rebaseline the PRs against the 3.1 branch this weekend.

Regarding ImageBrush I was just looking over the code and I don't see how that would effected by these issues at all, this one is about the final blending stage and that's handled differently over there, and the other doesn't makes sense for textures either... I'm fairly sure that these changes should only effect the explicit DrawImage api.

@JimBobSquarePants

JimBobSquarePants commented Dec 8, 2023

Copy link
Copy Markdown
Member

Thanks, appreciate it. See here for what I mean with the ImageBrush. It does the same reset of the position when given negative location. That’s why I exposed the rectangle constructor.

SixLabors/ImageSharp.Drawing#305

gfoidl
gfoidl reviewed Dec 9, 2023
View reviewed changes
Comment thread src/ImageSharp/Processing/Processors/Drawing/DrawImageProcessor{TPixelBg,TPixelFg}.cs Outdated
Comment thread src/ImageSharp/Processing/Processors/Drawing/DrawImageProcessor{TPixelBg,TPixelFg}.cs Outdated
@tocsoft
tocsoft changed the base branch from main to release/3.1.x December 9, 2023 10:32
@tocsoft tocsoft changed the title Handle case when Foreground image overhangs bottom of background image during DrawImage Call Handle case when Foreground image overhangs bottom of background image during DrawImage Call (3.1 target) Dec 9, 2023
@tocsoft

tocsoft commented Dec 9, 2023

Copy link
Copy Markdown
Member Author

JimBobSquarePants
JimBobSquarePants approved these changes Dec 9, 2023
View reviewed changes

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here!

@tocsoft
tocsoft merged commit 6863127 into release/3.1.x Dec 10, 2023
@tocsoft
tocsoft deleted the issue/2603 branch December 10, 2023 10:16
@tocsoft tocsoft mentioned this pull request Dec 10, 2023
Merged
4 tasks done
This was referenced Jul 30, 2025
Open
Closed
Open
Open
This was referenced Sep 29, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Oct 13, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Nov 3, 2025
Closed
This was referenced Nov 17, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Dec 18, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Feb 3, 2026
Merged
This was referenced Oct 15, 2026
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes
+1 more reviewer
@gfoidl gfoidl gfoidl left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Calling DrawImage with top image that overhangs bottom image in Y direction fails with exception

3 participants

@tocsoft @JimBobSquarePants @gfoidl