ensure raw is present in joined output by shivnagarajan · Pull Request #3 · Shopify/stackprof · GitHub
Skip to content

ensure raw is present in joined output#3

Merged
shivnagarajan merged 2 commits into
masterfrom
fix_raw_profiles
Apr 18, 2016
Merged

ensure raw is present in joined output#3
shivnagarajan merged 2 commits into
masterfrom
fix_raw_profiles

Conversation

@shivnagarajan

Copy link
Copy Markdown

Essentially when stackprof concatenates files together, it normalises the frames from each "file" using an MD5 based on file/line etc. For raw data there are two problems

a) raw data was not being output to the "combined" file
b) raw frames were not being normalised.

This change does the above two things. This is an upstream issue, but without this, generating raw frames for "flamegraphs" is hit-and-miss. (hit-and-miss because it depends on whether the data that was collected in the middleware was multiple files or just one file).

@fbogsany @csfrancis @camilo

This works generating raw frames and flamegraphs each time now. :-)

This is similar to the earlier request, except that it is for shopify/stackprof master. The previous one was a diff against 0.28, which I will do separately.

I plan to open this issue for the upstream code also.

@shivnagarajan

Copy link
Copy Markdown
Author

@shivnagarajan

Copy link
Copy Markdown
Author

@csfrancis

Copy link
Copy Markdown

Code LGTM, only suggestion would be to possibly add some comments to normalized_frames as it's pretty hard to understand what it's doing.

@shivnagarajan

Copy link
Copy Markdown
Author

add comments.

@fbogsany

Copy link
Copy Markdown
Member

LGTM 👍

@csfrancis

Copy link
Copy Markdown

@shivnagarajan shivnagarajan merged commit 97ead0d into master Apr 18, 2016
@shivnagarajan shivnagarajan deleted the fix_raw_profiles branch April 18, 2016 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants