{{ message }}
ensure raw is present in joined output#3
Merged
Conversation
Author
Author
|
Code LGTM, only suggestion would be to possibly add some comments to |
Author
|
add comments. |
Member
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Essentially when stackprof concatenates files together, it normalises the frames from each "file" using an MD5 based on file/line etc. For raw data there are two problems
a) raw data was not being output to the "combined" file
b) raw frames were not being normalised.
This change does the above two things. This is an upstream issue, but without this, generating raw frames for "flamegraphs" is hit-and-miss. (hit-and-miss because it depends on whether the data that was collected in the middleware was multiple files or just one file).
@fbogsany @csfrancis @camilo
This works generating raw frames and flamegraphs each time now. :-)
This is similar to the earlier request, except that it is for shopify/stackprof master. The previous one was a diff against 0.28, which I will do separately.
I plan to open this issue for the upstream code also.