Repository navigation
MiniMax-M3 NVFP4 B300 fp4 vLLM AgentX: tuned config-only curve on nightly-ac68c308 / MiniMax-M3 NVFP4 B300 fp4 vLLM AgentX：基于 nightly-ac68c308 的纯配置调优曲线 - #4357
Conversation
hshrivastava-droid
added
the
full-sweep-enabled
…htly-ac68c308 / MiniMax-M3 NVFP4 B300 fp4 vLLM AgentX：基于 nightly-ac68c308 的纯配置调优曲线
1a6f2c7 to
b7c0601
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. Both the recipe and the master config are covered by NVIDIA CODEOWNERS, and the tuning picks are judgment calls, so it's worth having an owner take a look too.
What was reviewed:
- Recipe override names against the new conc-lists (TP8 c1, TP4 c1/c24, TP4 DRAM c36/c40). Each point has exactly one override, and no overrides are left over after the TP2 and c48/c64 removals.
- The new perf-changelog entry is appended at the end and leaves existing bytes untouched. It names the config key, and the image tag matches the master config.
- I looked at
max-num-seqs: 7on the TP4 c24 point, which is far below CONC 24 and well under the ~1.5x ratio the other points use. The hunt ruled it out as a bug, but an owner should confirm it's the intended tuning.max-num-active-seqs(c36/c40) is also used by no other recipe in the repo, so it depends on the new nightly image supporting it.
Extended reasoning...
The change is config-only: it bumps the digest-pinned vLLM nightly image for minimaxm3-fp4-b300-vllm-agentic-mtp, shrinks the search space, retunes the matching srt-slurm AgentX recipe overrides and appends one perf-changelog entry. It touches no security-sensitive surface. I deferred instead of approving because nvidia-master.yaml and the b300-* recipe directories have dedicated CODEOWNERS. The new values (max-num-seqs below CONC at c24, and a max-num-active-seqs arg no other recipe uses) are tuning choices that the owners are better placed to confirm.
This review covers commit 1a6f2c7, which is no longer the latest commit on this pull request; later commits are not covered by it.
This branch has not been deployed
1 participant
Description
Config-only update for
minimaxm3-fp4-b300-vllm-agentic-mtp.minimaxm3-fp4-b300-vllm-agentic-mtpvllm/vllm-openai:nightly-ac68c3087215e0a4f3cdfa218508c6aada57235d@sha256:98adb2311118263a453ec0acd5d4b72bda3db26cecc0fe8ffc94b9ab03c951f9Type of Change
Checklist
perf-changelog.yamlperf-changelog.yamlentries are appended to the end of the file (the file is chronological: oldest at top, newest at bottom)OWNER/MEMBER/COLLABORATOR) has commented/reuse-sweep-runon this PR — do this only once there is a final full sweep that is all green with evals passing, since after this comment the sweep label will no longer automatically kick off new sweeps (remove and re-add the label to force one)