Privacy Policy (cont.) up2date by GrahamSH-LLK · Pull Request #41 · ScratchAddons/website · GitHub
Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Privacy Policy (cont.) up2date - #41

Closed
GrahamSH-LLK wants to merge 9 commits into
masterfrom
privacy-up2date
Closed

GrahamSH-LLK wants to merge 9 commits into
masterfrom
privacy-up2date

Conversation

@GrahamSH-LLK

@GrahamSH-LLK GrahamSH-LLK commented Oct 27, 2020 •

Copy link
Copy Markdown
Member

Continuation of #27 , resolves #24.

@WorldLanguages, you do the merge as you are the project leader. Up to date version of #27.

@williamhorning williamhorning left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything except footer.html is fine, we just need to add a rel="noopener" attribute to the privacy policy link.

Comment thread site/_includes/footer.html Outdated

@Hans5958 Hans5958 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to do this but I'm uncertaim of the compability of this PR. Stand by.

@williamhorning williamhorning left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the noopener issue, this seems good to go.

@Hans5958

Copy link
Copy Markdown
Member

@Hans5958 Hans5958 closed this Oct 30, 2020
@Hans5958
Hans5958 deleted the privacy-up2date branch November 15, 2020 03:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Privacy Issue] Add a disclaimer about use of Google Analytics

3 participants