iframe-proxy

B67687 · 2026-04-29T09:21:16Z

I have read the Contributing Guide.

Summary

Update version from 22.3.1 to 25.0.2
Fix checkver regex from vm- to jdk- pattern
Use extract_to + installer script for consistent extraction
Update autoupdate to use jdk- URL pattern

This was missed in previous PRs (#591, #592) which fixed the version-specific graalvm manifests but left the generic graalvm.json behind.

Validation

checkver.ps1 graalvm -> 25.0.2
checkurls.ps1 graalvm -> [1][1][0]

Summary by CodeRabbit

Chores
- Upgraded bundled JDK from GraalVM CE 22.3.1 to Community JDK 25.0.2.
- Switched to the Windows x64 binary distribution and refreshed checksum for the new artifact.
- Updated version detection to use GitHub releases and adjusted autoupdate artifact naming.
- Installation now uses a temporary staged install step for cleaner, atomic deployment.

- Update version from 22.3.1 to 25.0.2 - Fix checkver regex from vm- to jdk- pattern - Use extract_to + installer script for consistent extraction - Update autoupdate to use jdk- URL pattern

coderabbitai · 2026-04-29T09:21:24Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 25abe624-2202-4b9d-bd14-e1635204fef9

📥 Commits

Reviewing files that changed from the base of the PR and between 503ab42 and 1a39e12.

📒 Files selected for processing (1)

bucket/graalvm.json

Walkthrough

Manifest updated to target GraalVM Community JDK 25.0.2: download URL and SHA256 changed, extraction moved to a temporary folder with a PowerShell installer that relocates files to the final install dir and cleans up, and version detection/autoupdate switched to GitHub release tags (jdk-).

Changes

GraalVM Manifest

Layer / File(s)	Summary
Payload & installer extraction `bucket/graalvm.json`	Bumped to `jdk-25.0.2`; updated download `url` and `hash` to the `jdk-25.0.2_windows-x64_bin.zip` artifact; replaced `extract_dir` with `extract_to: "tmp"` and added a PowerShell `installer.script` that moves extracted contents into `$dir` and deletes the temp folder.
Version detection & autoupdate `bucket/graalvm.json`	`checkver` changed to query GitHub Releases and extract versions from `tag_name` using `jdk-<version>`; `autoupdate.url` adjusted to the new `jdk-$version` artifact naming.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Scoop
    participant GitHub as "GitHub Releases"
    participant TempFS as "tmp (extract)"
    participant PowerShell
    participant InstallFS as "install_dir"

    User->>Scoop: scoop install graalvm
    Scoop->>GitHub: download jdk-25.0.2_windows-x64_bin.zip
    GitHub-->>Scoop: zip file
    Scoop->>TempFS: extract zip to tmp/
    TempFS-->>PowerShell: provide extracted path
    PowerShell->>InstallFS: move files to final install_dir
    PowerShell->>TempFS: remove tmp/
    PowerShell-->>Scoop: return success
    Scoop-->>User: install complete

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

ScoopInstaller/Java#591: Modifies GraalVM manifest checkver/regex to match updated release artifacts.
ScoopInstaller/Java#563: Adds/updates GraalVM 25 manifest with GitHub-based checkver and installer-style extraction flow.
ScoopInstaller/Java#592: Updates GraalVM CE manifests to use GitHub-release-tag-based checkver and tmp-extract + PowerShell installer pattern.

Suggested reviewers

se35710
chawyehsu

Poem

🐰 I hopped through zips and tmp-folders bright,

PowerShell nudged each file into light.
From vm to jdk, twenty-five's the tune—
Temp cleaned, files settled, under the moon. 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main changes: updating GraalVM to version 25.0.2 and fixing the checkver regex pattern, which aligns with the primary objectives of the changeset.
Description check	✅ Passed	The description is comprehensive with a clear summary section, validation results, and context about previous related PRs, though it lacks an explicit issue reference (Closes/Relates `#XXXX`) from the template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2026-04-29T10:05:48Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-04-29T11:59:28Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-04-29T12:58:30Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-04-29T14:23:21Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/graalvm.json`:
- Around line 21-22: The current regex string "jdk-(25[\\d.]*)" hard-codes major
version 25; update the value associated with the "regex" key (the
"jdk-(25[\\d.]*)" literal) to a major-agnostic pattern such as "jdk-([\\d.]+)"
or "jdk-([0-9]+(?:\\.[0-9]+)*)" so future jdk-26/27... releases are matched
automatically while preserving the capture group used by the checkver logic.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e06055c6-66c9-4989-9d5b-1dc820980a6c

📥 Commits

Reviewing files that changed from the base of the PR and between ef20951 and 809e0c5.

📒 Files selected for processing (1)

bucket/graalvm.json

CodeRabbit suggestion: change regex from jdk-(25[\d.]*) to jdk-([\d.]+) to support future jdk-26, jdk-27, etc. releases

coderabbitai · 2026-04-29T15:32:40Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-04-29T15:33:08Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

🧹 Nitpick comments (1)

bucket/graalvm.json (1)

9-14: Harden installer script for future archive layout changes

Current logic on Line 11 only moves contents from child directories under tmp. If a future release ships files directly in tmp (no subdirectory), install would remove tmp without moving payload.

Proposed hardening

     "installer": {
         "script": [
-            "(Get-ChildItem -Directory \"$dir\\tmp\").FullName | % { Move-Item \"$_\\*\" \"$dir\" }",
-            "Remove-Item -Recurse \"$dir\\tmp\""
+            "$tmp = Join-Path $dir 'tmp'",
+            "$dirs = Get-ChildItem -Directory $tmp",
+            "if ($dirs) { $dirs | ForEach-Object { Move-Item (Join-Path $_.FullName '*') $dir -Force } } else { Move-Item (Join-Path $tmp '*') $dir -Force }",
+            "Remove-Item -Recurse -Force $tmp"
         ]
     },

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bucket/graalvm.json` around lines 9 - 14, The installer script currently only
moves contents from child directories under "tmp"; update the installer.script
to move all entries (files and folders) from "$dir\\tmp\\*" into "$dir" before
removing "$dir\\tmp" so payloads placed directly in tmp are preserved; replace
the existing Move-Item/Get-ChildItem pipeline with a single Move-Item
"$dir\\tmp\\*" "$dir" (add -Force and -ErrorAction Stop as needed) and then
Remove-Item -Recurse "$dir\\tmp" to safely clean up.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@bucket/graalvm.json`:
- Around line 9-14: The installer script currently only moves contents from
child directories under "tmp"; update the installer.script to move all entries
(files and folders) from "$dir\\tmp\\*" into "$dir" before removing "$dir\\tmp"
so payloads placed directly in tmp are preserved; replace the existing
Move-Item/Get-ChildItem pipeline with a single Move-Item "$dir\\tmp\\*" "$dir"
(add -Force and -ErrorAction Stop as needed) and then Remove-Item -Recurse
"$dir\\tmp" to safely clean up.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c4cd4f72-c796-4d08-9ef5-e50dd6617c78

📥 Commits

Reviewing files that changed from the base of the PR and between 809e0c5 and 922aa5d.

📒 Files selected for processing (1)

bucket/graalvm.json

github-actions · 2026-04-29T15:51:14Z

All changes look good.

Wait for review from human collaborators.

graalvm

Check the full log for details.

coderabbitai · 2026-04-30T00:03:28Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

github-actions · 2026-04-30T00:07:03Z

All changes look good.

Wait for review from human collaborators.

graalvm

Check the full log for details.

Changed from /releases/latest redirect (unreliable) to GitHub API with jsonpath + regex, matching the established convention used by graalvm-ce-17jdk.json and other version-specific graalvm manifests.

github-actions · 2026-05-22T00:22:29Z

All changes look good.

Wait for review from human collaborators.

graalvm

Check the full log for details.

B67687 · 2026-06-13T01:05:29Z

graalvm: update to latest 25.0.2 and fix checkver

809e0c5

- Update version from 22.3.1 to 25.0.2 - Fix checkver regex from vm- to jdk- pattern - Use extract_to + installer script for consistent extraction - Update autoupdate to use jdk- URL pattern

coderabbitai Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread bucket/graalvm.json Outdated

B67687 added 2 commits April 29, 2026 22:43

chore: add trailing newline

d9e6040

fix: make checkver regex version-agnostic

922aa5d

CodeRabbit suggestion: change regex from jdk-(25[\d.]*) to jdk-([\d.]+) to support future jdk-26, jdk-27, etc. releases

coderabbitai Bot reviewed Apr 29, 2026

View reviewed changes

chore: harden installer script for future archive layout changes

503ab42

B67687 force-pushed the fix/graalvm-checkver branch from 434e5b1 to 503ab42 Compare April 29, 2026 15:42

github-actions Bot added the review-needed label Apr 29, 2026

fix: use GitHub API checkver matching graalvm-ce-17jdk convention

1a39e12

Changed from /releases/latest redirect (unreliable) to GitHub API with jsonpath + regex, matching the established convention used by graalvm-ce-17jdk.json and other version-specific graalvm manifests.

B67687 closed this by deleting the head repository Jun 8, 2026

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

B67687 commented Apr 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot commented Apr 29, 2026

Uh oh!

coderabbitai Bot commented Apr 29, 2026

Uh oh!

coderabbitai Bot commented Apr 29, 2026

Uh oh!

coderabbitai Bot commented Apr 29, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 29, 2026

Uh oh!

coderabbitai Bot commented Apr 29, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 29, 2026

graalvm

Uh oh!

coderabbitai Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

graalvm

Uh oh!

github-actions Bot commented May 22, 2026

graalvm

Uh oh!

B67687 commented Jun 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

B67687 commented Apr 29, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 29, 2026 •

edited

Loading