{{ message }}
Add 'Good First Issue' label to reasons an issue doesn't go stale - #4317
Merged
bjlittle merged 3 commits intoSep 15, 2021
Merged
Conversation
Contributor
Author
Member
|
@wjbenfold I'm happy to merge "as is" and observe the subsequent GHA behaviour without specifically testing this change, so that's fine 👍 |
bjlittle
requested changes
Sep 15, 2021
Member
There was a problem hiding this comment.
@wjbenfold Awesome, thanks 👍
Could you also add a whatsnew entry in the documentation to cover this? I guess we could categorise it under the Internal section.
Also, there is just one comment to service, then we'll get this contribution banked 😄
Comment on lines
+218
to
+224
Member
There was a problem hiding this comment.
@wjbenfold Lovely contribution, thanks, but let's separate concerns here.
I'd prefer that you removed this update to the docs from this PR and include it in a separate PR.
Is that okay?
Contributor
Author
There was a problem hiding this comment.
Huh, I didn't think I'd added this file and I can't see from my command history how it got in here. I'll remove it
bjlittle
approved these changes
Sep 15, 2021
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Sep 19, 2021
* main: (71 commits) Skip TestConstrainedLoad if data missing (SciTools#4319) Add 'Good First Issue' label to reasons an issue doesn't go stale (SciTools#4317) Gallery: simplify quiver example (SciTools#4120) Improve styling in a minor way in docs (SciTools#4314) bump version (SciTools#4310) Made clear we only test on Linux. (SciTools#4309) Updated environment lockfiles (SciTools#4308) Include Discussions in Getting Involved. (SciTools#4307) Fixed text to show as link. (SciTools#4305) [pre-commit.ci] pre-commit autoupdate (SciTools#4299) Updated environment lockfiles (SciTools#4298) cartopy feature download (SciTools#4304) Mesh Loading (AVD-1813) (SciTools#4262) reset whatsnew latest (SciTools#4288) Updated environment lockfiles (SciTools#4289) Update cube.py (SciTools#4287) Integrated whatsnew for v3.1 release (rc0) (SciTools#4285) Version changes and final whatsnew tweaks for 3v1rc0. (SciTools#4284) Missing whatsnew entries for 3.1 release. (SciTools#4283) Update CF standard name table to v77 (SciTools#4282) ...
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Sep 22, 2021
* main: (94 commits) added support for make html-noapi and html-quick for the docs build (SciTools#4333) Refactor some netcdf save code (SciTools#4301) [pre-commit.ci] pre-commit autoupdate (SciTools#4329) Update to loading docs to cover absence of 'or' for constraints (SciTools#4321) update latest.rst.template (SciTools#4323) stable cartopy feature download (SciTools#4328) Skip TestConstrainedLoad if data missing (SciTools#4319) Add 'Good First Issue' label to reasons an issue doesn't go stale (SciTools#4317) Gallery: simplify quiver example (SciTools#4120) Improve styling in a minor way in docs (SciTools#4314) bump version (SciTools#4310) Made clear we only test on Linux. (SciTools#4309) Updated environment lockfiles (SciTools#4308) Include Discussions in Getting Involved. (SciTools#4307) Fixed text to show as link. (SciTools#4305) [pre-commit.ci] pre-commit autoupdate (SciTools#4299) Updated environment lockfiles (SciTools#4298) cartopy feature download (SciTools#4304) Mesh Loading (AVD-1813) (SciTools#4262) reset whatsnew latest (SciTools#4288) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Added "Good First Issue" to the exempt list for both exempt-issue-labels and exempt-pr-labels so that these won't be made stale.
Based on a suggestion by @trexfeathers in Peloton today, stopping good first issues from going stale means that there's a supply of them for new developers to get involved through (particularly as there aren't a huge number of them).
Consult Iris pull request check list