fix: model does not stop on stop_training == true #1170 by asaf92 · Pull Request #1171 · SciSharp/TensorFlow.NET · GitHub
Skip to content

fix: model does not stop on stop_training == true #1170#1171

Merged
Oceania2018 merged 1 commit intoSciSharp:masterfrom
asaf92:patch-1
Sep 13, 2023
Merged

fix: model does not stop on stop_training == true #1170#1171
Oceania2018 merged 1 commit intoSciSharp:masterfrom
asaf92:patch-1

Conversation

@asaf92
Copy link
Copy Markdown
Contributor

@asaf92 asaf92 commented Sep 10, 2023

Did not test it, but debugging showed that this is the code that is missing. stop_training is only updated but never used.

This solves #1170

@asaf92 asaf92 requested a review from Oceania2018 as a code owner September 10, 2023 15:09
@asaf92 asaf92 changed the title fix: model does not stop on stop_training == true (solves #1170) fix: model does not stop on stop_training == true #1170 Sep 10, 2023
@Wanglongzhi2001
Copy link
Copy Markdown
Contributor

Wanglongzhi2001 commented Sep 11, 2023

@Oceania2018 Oceania2018 merged commit a91e358 into SciSharp:master Sep 13, 2023
@asaf92 asaf92 deleted the patch-1 branch September 14, 2023 12:08
@asaf92
Copy link
Copy Markdown
Contributor Author

asaf92 commented Sep 14, 2023

Hey @Wanglongzhi2001, thank you for accepting my PR!
I noticed that the automatic nightly release has not worked for the last ~2 months. Is there a release planned in the near future where this change will be included?

@Oceania2018
Copy link
Copy Markdown
Member

Released v0.110.3. Can you check if this version works?

@GaijinOtohp
Copy link
Copy Markdown
Contributor

Released v0.110.3. Can you check if this version works?

It seems to work if "Tensorflow.Keras.dll" is directly generated from the current version of the repository. But not from the released v0.110.3.

@asaf92
Copy link
Copy Markdown
Contributor Author

asaf92 commented Sep 19, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants