refactor: Model.eval by DevNullx64 · Pull Request #1092 · SciSharp/TensorFlow.NET · GitHub
Skip to content

refactor: Model.eval#1092

Merged
Oceania2018 merged 6 commits intoSciSharp:masterfrom
DevNullx64:Dev
Jun 18, 2023
Merged

refactor: Model.eval#1092
Oceania2018 merged 6 commits intoSciSharp:masterfrom
DevNullx64:Dev

Conversation

@DevNullx64
Copy link
Copy Markdown
Contributor

No description provided.

IModel.Dictionary<string, float> evaluate(NDArray, NDArray, ...) is now IModel.Dictionary<string, float> evaluate(Tensor, Tensor, ...)
Merge Model.Evaluate.test_step_multi_inputs_function(...) and Model.Evaluate.test_function(...)

Note: An internal function need to add an explicit cast in Tensor
@DevNullx64 DevNullx64 requested a review from Oceania2018 as a code owner June 4, 2023 22:08
@SanftMonster SanftMonster changed the title Refactor: Model.eval refactor: Model.eval Jun 5, 2023
@Wanglongzhi2001
Copy link
Copy Markdown
Contributor

@Wanglongzhi2001
Copy link
Copy Markdown
Contributor

BTW, in the test_step_multi_inputs_function of Model.Evaluate, should train_step be changed to test_step,? can you help change it?

@DevNullx64
Copy link
Copy Markdown
Contributor Author

Thank !
It's my mess, I've not well seen this. I'm on it :)

Fix my bad:

Bad handling between test_function and test_step_multi_inputs_function.
@DevNullx64
Copy link
Copy Markdown
Contributor Author

thank @AsakusaRinne to had change pull request title. I will try to take care next.
@Wanglongzhi2001, it should be done. But is it a normal behaviour to have "step_train" here ?

@Wanglongzhi2001
Copy link
Copy Markdown
Contributor

Looks good to me.

@Oceania2018 Oceania2018 merged commit e1ece66 into SciSharp:master Jun 18, 2023
@Wanglongzhi2001
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants