{{ message }}
Repository navigation
Initialize translational acceleration sensor test - #489
Merged
ChrisRackauckas merged 1 commit intoJul 21, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
Member
Author
|
CI classification for the independent SISO failures:
QA and documentation are green. Downstream remains in progress. |
Member
Author
|
I independently audited the remaining red jobs here. The translational file passes with this PR's change; the failures occur later in clean-main
Draft #491 is the separate focused fix. Its |
Member
Author
This was referenced Jul 15, 2026
ChrisRackauckas
marked this pull request as ready for review
July 21, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
TranslationalPosition.AccelerationSensortest mass.Root cause
The test constructed
TranslationalPosition.Mass(m = 4)and then passed no initial conditions toODEProblem(...; fully_determined = true). Current ModelingToolkit therefore correctly reports an underdetermined initialization system rather than selecting arbitrary initial position and velocity values.ModelingToolkit source-history bisection identified
b0f31536949370d189c03df71bc38f692a9a6975(fix: avoid false positives in consistency check) as the first bad commit for this fixture:80f7f62bc0a8925dfef88f149c111c6dc812415econstructed the problem only because alias elimination silently forced underconstrained variables to zero.b0f3153694intentionally replaced that behavior withIgnoreUnderconstrainedVariable; the same fixture then reported 4 highest-order derivative variables for 2 equations, includingmass₊sˍt(t)andacc₊flange₊s(t).Giving the mass explicit zero position and velocity is the physical assumption the test already relied on. This is distinct from the closed
outputs=attempt in #450: outputs do not change structural balance. An explicit internal velocity insideAccelerationSensorwas also tested and did not fix initialization; it only moved the singular variable.Local verification
Using registry ModelingToolkit 11.31.2 and ModelingToolkitBase 1.51.1:
06464384:test/translational.jlpassed 16/16 (Free2/2; spring/damper/mass/fixed 4/4; driven 4/4; sources and sensors 6/6).acc_output ≈ mass.f / m.git diff --checkpassed.Process log
outputs=and internal-velocity hypotheses.b0f3153694and inspected its removal of silent zeroing.