Initialize the FixedHeatFlow algebraic state by ChrisRackauckas-Claude · Pull Request #487 · SciML/ModelingToolkitStandardLibrary.jl · GitHub
Skip to content

Initialize the FixedHeatFlow algebraic state - #487

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:agent/fixed-heatflow-downgrade-audit
Jul 13, 2026
Merged

ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:agent/fixed-heatflow-downgrade-audit

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

This PR should be ignored until reviewed by @ChrisRackauckas.

Summary

  • Initialize the remaining FixedHeatFlow port temperature to its physical 299 K value in the thermal regression test.
  • Preserve the original solver, assertions, expected values, and tolerances.

Why

The exact downgrade workflow graph selected by julia-actions/julia-downgrade-compat at fab1defb76df9fd672f63c94df73ce131d32e134 uses ModelingToolkit 11.2.0. On clean main, that graph leaves the only reduced state at Inf, so initialization returns InitialFailure even though the observed heat flow is already 1 W. A 1 W flow across the 1 K/W wall places this port 1 K below the 300 K source, so the explicit 299 K initial value is model-consistent.

Commit c44704f3 is the repository boundary that made the empty-GROUP downgrade invocation execute Core tests. The earlier apparent green run failed during precompilation and then executed zero tests. With current ModelingToolkit 11.31.2, the same model derives 299 K and succeeds without the explicit value; the added fixture keeps the minimum-compatible graph valid.

Draft #485 independently addresses the clean-main piston failure encountered later in Core. This PR deliberately leaves the piston model unchanged.

Local validation

  • Exact downgraded graph, Julia 1.10.11: include("test/thermal.jl") — 19/19 passed, including FixedHeatFlow 2/2.
  • Native GROUP=Core Pkg.test() on the exact downgraded graph: every preceding file passed through nonlinear 15/15; execution then reached the known clean-main piston error addressed by draft Define the piston test independent variable #485.
  • Runic 1.7 whole-repository check: passed.
  • git diff --check: passed.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

CI downgrade classification for exact head dc1d11a96fa819b5aeae2b5398a0cc640ff7390a:

The downgrade job resolved and ran Core successfully through Core/nonlinear.jl (15/15), then stopped in Core/piston.jl with the clean-main _check_if_dde(...PleaseImportDynamicQuantities...) error already investigated and fixed by draft #485. Because piston.jl precedes thermal.jl in the Core folder order, this CI run did not reach the FixedHeatFlow regression; it therefore neither contradicts nor independently confirms the local exact-graph test/thermal.jl result (19/19, FixedHeatFlow 2/2).

No test was skipped or silenced here. Runic, Runic suggestions, discovery, and spell checks are green on this head. The remaining CI result is a known prerequisite failure, not a failure of the changed assertion.

Copy link
Copy Markdown
Member Author

@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 13, 2026 19:53
@ChrisRackauckas
ChrisRackauckas merged commit 3a162d1 into SciML:main Jul 13, 2026
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants