fix: device display name resetting on sync (#1735) by RoootTheFox · Pull Request #1939 · SableClient/Sable · GitHub
Skip to content

fix: device display name resetting on sync (#1735) - #1939

Merged
7w1 merged 2 commits into
SableClient:devfrom
RoootTheFox:rooot/revert-usedevicedisplayname
Aug 25, 2026
Merged

fix: device display name resetting on sync (#1735)#1939
7w1 merged 2 commits into
SableClient:devfrom
RoootTheFox:rooot/revert-usedevicedisplayname

Conversation

@RoootTheFox

@RoootTheFox RoootTheFox commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

this essentially just reverts #1458, as it doesn't do anything useful besides introducing a bug.

Description

Fixes #1735

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • i deleted the broken code with my own two paws
  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@RoootTheFox
fix: device display name resetting on sync (SableClient#1735)
287ed77 
this essentially just reverts SableClient#1458, as it doesn't do
anything useful besides introducing a bug.

Signed-off-by: rooot <hey@rooot.gay>
@RoootTheFox

RoootTheFox commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

7w1
7w1 reviewed Aug 25, 2026
View reviewed changes
Comment thread .changeset/fix-device-names-resetting.md Outdated
@RoootTheFox
feat: set default device name when no name is provided
273b55b 
Signed-off-by: rooot <hey@rooot.gay>
@RoootTheFox
RoootTheFox force-pushed the rooot/revert-usedevicedisplayname branch from 669005b to 273b55b Compare August 25, 2026 01:08
7w1
7w1 approved these changes Aug 25, 2026
View reviewed changes

@7w1 7w1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@7w1
7w1 enabled auto-merge August 25, 2026 01:09
@7w1
7w1 added this pull request to the merge queue Aug 25, 2026
Merged via the queue into SableClient:dev with commit f946bb8 Aug 25, 2026
12 of 13 checks passed
@sable-actions sable-actions Bot mentioned this pull request Aug 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7w1 7w1 7w1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Nightly] Device name is reset on login (and shouldn't be)

2 participants

@RoootTheFox @7w1