Enhancements and bug fixes by mindbrix · Pull Request #9 · SVGKit/SVGKit · GitHub
Skip to content

Enhancements and bug fixes#9

Closed
mindbrix wants to merge 1 commit into
SVGKit:masterfrom
mindbrix:Enhancements
Closed

Enhancements and bug fixes#9
mindbrix wants to merge 1 commit into
SVGKit:masterfrom
mindbrix:Enhancements

Conversation

@mindbrix

Copy link
Copy Markdown

Support for floating point coordinates. Support for relative path
coordinates. Parser bug fixes and improvements. Added more examples to
test the renderer.

Support for floating point coordinates. Support for relative path
coordinates. Parser bug fixes and improvements. Added more examples to
test the renderer.
@steipete

Copy link
Copy Markdown

@mindbrix

Copy link
Copy Markdown
Author

Good point. Is there any way to trim the commit. I'm still learning Git after years of SVN.

@steipete

Copy link
Copy Markdown

Uhh... best way would be to rewrite history, to purge the files completely, It's a bit tricky, google has some good answers on this. And add a .gitignore, it's really the repository master's fault ;) (and then re-open another request)

@jwang

jwang commented Aug 26, 2011

Copy link
Copy Markdown

Look at GitHub crowd-sourced gitignore repo. It's got an Objective-C one, core OS ones for mac and more.

@mindbrix

Copy link
Copy Markdown
Author

Thanks. The Objective-C .gitignore doesn't seem to play nicely with Github for Mac yet.

@reklis

reklis commented Sep 15, 2011

Copy link
Copy Markdown

just pull into a branch and pull out whatever you want with git diff into a patch file, then apply the patch to whatever other branch directly.

@adamgit

adamgit commented May 6, 2012

Copy link
Copy Markdown
Contributor

FYI I'm planning to CLOSE this request WITHOUT MERGING.

I want to overwrite the main repository with the reklis fork - there are over 1,000 new lines, and 500 changed, since the last update to master. I believe all the changes in this pull request now exist in the reklis fork - either merged in, or have been reproduced by someone else?

If so - no work needed, they're already in place, and will be included automatically.

If not - please could you try re-applying your changes to the reklis fork, and see if it works OK?

Thanks!

@mindbrix

mindbrix commented May 7, 2012

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants