Upgrade the framework version to 2.1.0#597
Conversation
|
@adamgit This is the prepare before we release v2.1.0. Please have a check. |
|
@adamgit Any reason we generate the static library with that version number ? Why not just |
|
I am not sure, but ... I think it's a standard that Apple/Xcode used? I agree that if we could get safely remove the version from the name then it would make the library easier for us to maintain! |
| 663FCFF616C9AF3C00CCBFB3 /* Sample Licenses from svg-android project.txt in Resources */ = {isa = PBXBuildFile; fileRef = 663FCFF516C9AF3C00CCBFB3 /* Sample Licenses from svg-android project.txt */; }; | ||
| 663FD00416CAB16B00CCBFB3 /* groups-and-layers-test.svg in Resources */ = {isa = PBXBuildFile; fileRef = 663FD00316CAB16B00CCBFB3 /* groups-and-layers-test.svg */; }; | ||
| 6649E0AD1617479200AFE92A /* QuartzCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 6649E0AC1617479200AFE92A /* QuartzCore.framework */; }; | ||
| 6649E10D1617577000AFE92A /* libSVGKit-iOS.2.0.0.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 6649E10A1617574700AFE92A /* libSVGKit-iOS.2.0.0.a */; }; |
There was a problem hiding this comment.
Now there's no libSVGKit-iOS.x.y.z.a at all?
This filed is safe. The number is just appended to file name...(This does not compiled to static library binary), but people who build static library by theirself, already know what the version is. So it's no need to add it at all (And cause we manual change that number each time release). I think we can just remove that. (actually this does not cause any issue....file name :)) See the static library from SDWebImage && CocoaLumberjack |
|
@adamgit Hi. Good news. It seems that after I sending the email to claim the owner of SVGKit from CocoaPods forum. They add you and me to the CocoaPods trunk owner. Now we can upload the podspec into the trunk. So that all CocoaPods user can use a release version instead of current branch dependency like So I'm waiting for your release of SVGKit 2.1.0. After you push a new git tag |
|
@adamgit I upload the And, is there any pending PR to merge for 2.1.0 release ? Maybe we can start a git tag release. The 2.0.0 can works for Xcode 10 now, but it still seems far away from the current 2.x branch lastest commit. |
|
Yes, I have everything setup to do a 2.1.0 tag + release - just waiting to
get the last few PR's merged + checked here :).
Version number / tag number I am planning to do the same as the 2.0.0
release - tag is "2.0.0" - ... NOT like the 1.2.0 release - where tag was
"v1.2.0".
NB: GitHub strongly encourages "v1.1.1" but I don't like having the "v" in
there, it has caused problems with other tools in the past. As I understand
it, you're saying tha both CP and Carthage agree here? :)
…On Tue, 30 Oct 2018 at 03:27, DreamPiggy ***@***.***> wrote:
@adamgit <https://github.com/adamgit> I upload the 2.0.0 version podspec
to the CocoaPod Trunk. CocoaPods user can now use the 2.0.0 tag release in
their podfile.
And, is there any pending PR to merge for 2.1.0 release ? Maybe we can
start a git tag release. The 2.0.0 can works for Xcode 10 now, but it still
seems far away from the current 2.x branch lastest commit.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#597 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAR1-XcP7WaqU8kxmdgqKZ_tkLcSWq7pks5up8cpgaJpZM4X_Sbv>
.
|
|
Both CocoaPods or Carthage, by default use the git tag for the raw version number. CocoaPods Carthage |






Upgrade the framework version to 2.1.0. After this PR was merged, we can create a git tag
2.1.0and release the new version.And I update the readme to introduce the macOS support for user.