iframe-proxy

danlavu · 2023-08-20T05:35:20Z

Adding functional authselect test cases

danlavu · 2023-08-22T13:44:29Z

============================= test session starts ==============================
collecting ... collected 29 items

tests/test_authselect.py::test_authselect__select_minimal_profile_with_local_user_auth (client) 
tests/test_authselect.py::test_authselect__minimal_profile_works_with_no_additional_packages (client) 
tests/test_authselect.py::test_authselect__when_removed_the_uninstall_is_clean (client) 
tests/test_authselect.py::test_authselect__select_sssd_profile_with_user_auth (ad) 
tests/test_authselect.py::test_authselect__select_sssd_profile_with_user_auth (ipa) 
tests/test_authselect.py::test_authselect__select_sssd_profile_with_user_auth (ldap) 
tests/test_authselect.py::test_authselect__select_sssd_profile_with_user_auth (samba) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_mkhomedir (ad) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_mkhomedir (ipa) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_mkhomedir (ldap) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_mkhomedir (samba) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_faillock (ad) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_faillock (ipa) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_faillock (ldap) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_faillock (samba) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_pam_sudo (ad) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_pam_sudo (ipa) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_pam_sudo (ldap) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_pam_sudo (samba) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_pam_access (ad) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_pam_access (ipa) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_pam_access (ldap) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_pam_access (samba) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_smartcard (client) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_smartcard_lock_on_removal (client) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_fingerprint (client) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_silent_lastlog (client) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_with_gssapi (client) 
tests/test_authselect.py::test_authselect__sssd_profile_enable_and_disable_with_subid (client) 

================== 27 passed, 2 skipped in 259.80s (0:04:19) ===================
PASSED [  3%]SKIPPED (unconditional skip) [  6%]
Skipped: unconditional skip
SKIPPED (unconditional skip) [ 10%]
Skipped: unconditional skip
PASSED [ 13%]PASSED [ 17%]PASSED [ 20%]PASSED [ 24%]PASSED [ 27%]PASSED [ 31%]PASSED [ 34%]PASSED [ 37%]PASSED [ 41%]PASSED [ 44%]PASSED [ 48%]PASSED [ 51%]PASSED [ 55%]PASSED [ 58%]PASSED [ 62%]PASSED [ 65%]PASSED [ 68%]PASSED [ 72%]PASSED [ 75%]PASSED [ 79%]PASSED [ 82%]PASSED [ 86%]PASSED [ 89%]PASSED [ 93%]PASSED [ 96%]PASSED [100%]
Process finished with exit code 0

This PR requires several framework PRs to be merged first.

SSSD/sssd-test-framework#29
SSSD/sssd-test-framework#31
SSSD/sssd-test-framework#36
SSSD/sssd-test-framework#38

ikerexxe

This is a first round of reviews. I didn't have time to check everything and I have an important question before proceeding.

Why do you want to test several things only in a given distribution? I see that the two test cases aren't customer cases, so what makes you think that they are valuable?

danlavu · 2023-08-23T19:38:47Z

@ikerexxe The requirement wasn't provided in the ported test suite. I did look up the requirements and added them.

These should be a functional test of all the features. Ideally, all sanity features should be functional, some can be reworked now, like with_gssaspi. Others will take more time, talking to @spoore1, to propose that "test_authselect__sssd_profile_enable_and_disable_smartcard" will be a simple case to add and test the certificate utility to the framework.

If there is a feature, we should test it. There are a number of features that are missing, with-ecryptfs, with-pam-u2f, with-pam-gnome-keyring, with no urgency, backlog, a nice to have?

Adding functional authselect test cases

ikerexxe · 2023-08-24T07:36:03Z

@ikerexxe The requirement wasn't provided in the ported test suite. I did look up the requirements and added them.

I didn't explain myself correctly. If possible, I'd like to run all test cases in all available distributions in CI. Is there anything in RHEL that does not allow us to do so?

These should be a functional test of all the features. Ideally, all sanity features should be functional, some can be reworked now, like with_gssaspi. Others will take more time, talking to @spoore1, to propose that "test_authselect__sssd_profile_enable_and_disable_smartcard" will be a simple case to add and test the certificate utility to the framework.

If there is a feature, we should test it. There are a number of features that are missing, with-ecryptfs, with-pam-u2f, with-pam-gnome-keyring, with no urgency, backlog, a nice to have?

You are absolutely right.

danlavu · 2023-08-24T19:29:46Z

danlavu added Tests no-backport This should go to target branch only. labels Aug 20, 2023

danlavu force-pushed the test_authselect branch 6 times, most recently from e6d51f4 to c3525ba Compare August 22, 2023 13:27

danlavu added the Waiting for review label Aug 22, 2023

danlavu requested a review from madhuriupadhye August 22, 2023 13:49

ikerexxe reviewed Aug 23, 2023

View reviewed changes

Comment thread src/tests/system/tests/test_authselect.py

Comment thread src/tests/system/tests/test_authselect.py

Comment thread src/tests/system/tests/test_authselect.py

Comment thread src/tests/system/tests/test_authselect.py

tests: authselect

ecd8126

Adding functional authselect test cases

danlavu force-pushed the test_authselect branch from c3525ba to ecd8126 Compare August 23, 2023 19:39

danlavu closed this Aug 24, 2023

danlavu mentioned this pull request Aug 24, 2023

tests: ported authselect tests from downstream authselect/authselect#349

Merged

danlavu deleted the test_authselect branch April 17, 2024 02:44

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tests: authselect#6890

tests: authselect#6890
danlavu wants to merge 1 commit into
SSSD:masterfrom
danlavu:test_authselect

danlavu commented Aug 20, 2023

Uh oh!

danlavu commented Aug 22, 2023 •

edited

Loading

Uh oh!

ikerexxe left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danlavu commented Aug 23, 2023

Uh oh!

ikerexxe commented Aug 24, 2023

Uh oh!

danlavu commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

danlavu commented Aug 20, 2023

Uh oh!

danlavu commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikerexxe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danlavu commented Aug 23, 2023

Uh oh!

ikerexxe commented Aug 24, 2023

Uh oh!

danlavu commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

danlavu commented Aug 22, 2023 •

edited

Loading