{{ message }}
Draft
Conversation
…ant color used in blending. Add 4 new values to the `sf::BlendMode::Factor` enum to allow the constant color to be used in the blending equation. Update the application of `sf::BlendMode` in `sf::RenderTarget` to allow the constant color to be used in the blending equation.
vittorioromeo
requested changes
Mar 2, 2026
Comment on lines
+718
to
+735
Member
There was a problem hiding this comment.
Perhaps something along the lines of:
const auto isBlendColorFactor = [](sf::BlendMode::Factor factor)
{
return factor == BlendMode::Factor::ConstColor ||
factor == BlendMode::Factor::OneMinusConstColor ||
factor == BlendMode::Factor::ConstAlpha ||
factor == BlendMode::Factor::OneMinusConstAlpha;
};
if (isBlendColorFactor(mode.colorSrcFactor) ||
isBlendColorFactor(mode.colorDstFactor) ||
isBlendColorFactor(mode.alphaSrcFactor) ||
isBlendColorFactor(mode.alphaDstFactor))
{
glCheck(glBlendColor(mode.constColor.r, mode.constColor.g, mode.constColor.b, mode.constColor.a));
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for constant color blending modes so as to resolve issue #1503.
Link to the relevant forum post: https://en.sfml-dev.org/forums/index.php?topic=24653.0
Tasks
How to test this PR?