iframe-proxy

cuishuang · 2026-09-08T14:56:31Z

I did not use AI to write the code of this patch.
This PR follows our AI policy

Summary

Passing -X int_max_str_digits without a value unwraps None and causes a Rust panic before reaching the existing configuration error handler.

Handle the optional value before parsing so missing values report the existing invalid limit diagnostic and exit with status 1.

AI assistance: Codex (GPT-6) assisted with the regression test, validation, and I have reviewed and understand the code.

Summary by CodeRabbit

Bug Fixes
- Invalid or missing -X int_max_str_digits values now produce a clear error instead of causing an interpreter panic.
- Valid limits, including 640 and 0, continue to be accepted and reported correctly.
Tests
- Added coverage for valid, invalid, and missing command-line option values.

coderabbitai · 2026-09-08T14:57:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: d4f0142b-b1a3-4fdb-b618-673162174d55

📥 Commits

Reviewing files that changed from the base of the PR and between 2193a15 and ebbe08c.

📒 Files selected for processing (1)

extra_tests/snippets/cli_int_max_str_digits.py

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The CLI now handles missing and invalid -X int_max_str_digits values through fatal errors without panicking. Tests cover invalid values and valid limits of 640 and 0.

Changes

Integer digit limit handling

Layer / File(s)	Summary
Option validation `src/settings.rs`	Missing or unparsable `int_max_str_digits` values now use the existing fatal error path.
CLI regression coverage `extra_tests/snippets/cli_int_max_str_digits.py`	Tests verify error output and exit codes for invalid values and configured output for valid limits.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ebbe0

Missing or invalid integer digit limits now produce the expected error instead of panicking, while valid limits continue to work. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: preventing a panic when -X int_max_str_digits has no value.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2193a15c7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-08T14:59:26Z

+for option in (
+    "int_max_str_digits",
+    "int_max_str_digits=639",
+    "int_max_str_digits=invalid",
+):


Remove the newly added test logic

This new snippet introduces test assertions, control flow, and test data, but the repository rules state that test assertions, logic, and data must not be modified and limit acceptable test-file changes to adding or removing expected-failure markers. Remove this test-file addition and keep the behavioral fix confined to the Rust implementation.

AGENTS.md reference: AGENTS.md:L273-L279

Useful? React with 👍 / 👎.

ShaharNaveh

tysm!

codspeed-hq · 2026-09-08T15:18:40Z

Merging this PR will degrade performance by 12.48%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 65 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`gc_collect.py[rustpython]`	206.6 ms	236.1 ms	-12.48%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing cuishuang:main (2193a15) with main (c6c1b1c)}

youknowone

Thank you for contributing! Please check lint failuire

https://github.com/RustPython/RustPython/actions/runs/34241535912/job/102112661455?pr=8677
clicking prek run will show you what's failing.

Everything others looks great. Thanks!

Signed-off-by: cuishuang <imcusg@gmail.com>

chatgpt-codex-connector · 2026-09-10T11:55:44Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

cuishuang · 2026-09-10T12:25:59Z

youknowone

👍

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

ShaharNaveh approved these changes Sep 8, 2026

View reviewed changes

youknowone requested changes Sep 10, 2026

View reviewed changes

cli: avoid panic when -X int_max_str_digits has no value

ebbe08c

Signed-off-by: cuishuang <imcusg@gmail.com>

cuishuang force-pushed the main branch from 2193a15 to ebbe08c Compare September 10, 2026 11:55

youknowone approved these changes Sep 10, 2026

View reviewed changes

youknowone merged commit 8195385 into RustPython:main Sep 10, 2026
28 checks passed

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

cli: avoid panic when -X int_max_str_digits has no value - #8677

cli: avoid panic when -X int_max_str_digits has no value#8677
youknowone merged 1 commit into
RustPython:mainfrom
cuishuang:main

cuishuang commented Sep 8, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 8, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Sep 8, 2026

Uh oh!

ShaharNaveh left a comment

Uh oh!

codspeed-hq Bot commented Sep 8, 2026

Uh oh!

youknowone left a comment

Uh oh!

chatgpt-codex-connector Bot commented Sep 10, 2026

Uh oh!

cuishuang commented Sep 10, 2026

Uh oh!

youknowone left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

cuishuang commented Sep 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

ShaharNaveh left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq Bot commented Sep 8, 2026

Merging this PR will degrade performance by 12.48%

Performance Changes

Uh oh!

youknowone left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Sep 10, 2026

Uh oh!

cuishuang commented Sep 10, 2026

Uh oh!

youknowone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cuishuang commented Sep 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 8, 2026 •

edited

Loading